admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #15695 from MikeMcQuaid/influxdb_analytics_message_fix_again

Browse Source 
Fix (again) InfluxDB analytics messaging
This commit is contained in:
Mike McQuaid 2023-07-18 08:43:18 +01:00 committed by GitHub
commit da01f8f0b9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
Library/Homebrew/cmd/update-report.rb
View File

@ -329,10 +329,16 @@ module Homebrew
end end
def analytics_message def analytics_message
if !Utils::Analytics.messages_displayed? && return if Utils::Analytics.messages_displayed?
!Utils::Analytics.disabled? && return if Utils::Analytics.no_message_output?
!Utils::Analytics.no_message_output?
if Utils::Analytics.disabled? && !Utils::Analytics.influx_message_displayed?
ohai "Homebrew's analytics have entirely moved to our InfluxDB instance in the EU."
puts "We gather less data than before and have destroyed all Google Analytics data:"
puts " #{Formatter.url("https://docs.brew.sh/Analytics")}#{Tty.reset}"
puts "Please reconsider re-enabling analytics to help our volunteer maintainers with:"
puts " brew analytics on"
elsif !Utils::Analytics.disabled?
ENV["HOMEBREW_NO_ANALYTICS_THIS_RUN"] = "1" ENV["HOMEBREW_NO_ANALYTICS_THIS_RUN"] = "1"
# Use the shell's audible bell. # Use the shell's audible bell.
print "\a" print "\a"
@ -345,19 +351,10 @@ module Homebrew
No analytics have been recorded yet (nor will be during this `brew` run). No analytics have been recorded yet (nor will be during this `brew` run).
EOS EOS
# Consider the messages possibly missed if not a TTY.
Utils::Analytics.messages_displayed! if $stdout.tty?
elsif Utils::Analytics.disabled?
ohai "Homebrew's analytics have entirely moved to our InfluxDB instance in the EU."
puts "We gather less data than before and have destroyed all Google Analytics data:"
puts " #{Formatter.url("https://docs.brew.sh/Analytics")}#{Tty.reset}"
puts "Please reconsider re-enabling analytics to help our volunteer maintainers with:"
puts " brew analytics on"
# Consider the message possibly missed if not a TTY.
Settings.write "influxanalyticsmessage", true if $stdout.tty?
end end
# Consider the messages possibly missed if not a TTY.
Utils::Analytics.messages_displayed! if $stdout.tty?
end end
def donation_message def donation_message

6
Library/Homebrew/utils/analytics.rb
View File

@ -108,10 +108,14 @@ options: options)
report_influx_event(:build_error, package_name: formula.name, tap_name: tap.name, options: options) report_influx_event(:build_error, package_name: formula.name, tap_name: tap.name, options: options)
end end
def influx_message_displayed?
config_true?(:influxanalyticsmessage)
end
def messages_displayed? def messages_displayed?
config_true?(:analyticsmessage) && config_true?(:analyticsmessage) &&
config_true?(:caskanalyticsmessage) && config_true?(:caskanalyticsmessage) &&
config_true?(:influxanalyticsmessage) influx_message_displayed?
end end
def disabled? def disabled?