rubocops/lines: Clean up an old TODO

- I considered writing a cop for this, but it's not worth it:
  there are no `[:test, :build]` occurrences in Core and this
  Rust rule only applies in Core formulae.
This commit is contained in:
Issy Long 2025-02-09 18:33:12 +00:00
parent be00598e63
commit d9b376a9cd
No known key found for this signature in database

View File

@ -938,9 +938,7 @@ module RuboCop
end end
end end
# TODO: Enforce order of dependency types so we don't need to check for [:build, [:build, :test]].each do |type|
# depends_on "rustup" => [:test, :build]
[:build, [:build, :test], [:test, :build]].each do |type|
find_method_with_args(body_node, :depends_on, "rustup" => type) do find_method_with_args(body_node, :depends_on, "rustup" => type) do
problem "Formulae in homebrew/core should use 'depends_on \"rust\" => #{type}' " \ problem "Formulae in homebrew/core should use 'depends_on \"rust\" => #{type}' " \
"instead of '#{@offensive_node.source}'." do |corrector| "instead of '#{@offensive_node.source}'." do |corrector|