From d9afb4f9ea54d2b6e4f04c1e6fe5f3b051258447 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Thu, 5 Dec 2013 16:39:39 -0600 Subject: [PATCH] bottle: fix reporting matches with spaces in them --- Library/Homebrew/cmd/bottle.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/cmd/bottle.rb b/Library/Homebrew/cmd/bottle.rb index 12eff8831b..ceaa3fa939 100644 --- a/Library/Homebrew/cmd/bottle.rb +++ b/Library/Homebrew/cmd/bottle.rb @@ -77,10 +77,9 @@ module Homebrew extend self # Use strings to search through the file for each string strings = `strings -t x - "#{file}"`.select{ |str| str.include? string }.map{ |s| s.strip } - # Don't bother reporting a string if it was found by otool - strings.reject!{ |str| linked_libraries.include? str.split[1] } strings.each do |str| - offset, match = str.split + offset, match = str.split(" ", 2) + next if linked_libraries.include? match # Don't bother reporting a string if it was found by otool puts " #{Tty.gray}-->#{Tty.reset} match '#{match}' at offset #{Tty.em}0x#{offset}#{Tty.reset}" end end