admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Add audit warning if previous Cask version cannot be read.

Browse Source
This commit is contained in:
Markus Reiter 2017-10-01 02:13:53 +02:00
parent 700300a76b
commit d9a474ed0e
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cask/lib/hbc/audit.rb
View File

@ -70,12 +70,16 @@ module Hbc
previous_cask_contents = Git.last_revision_of_file(tap.path, @cask.sourcefile_path, before_commit: commit_range) previous_cask_contents = Git.last_revision_of_file(tap.path, @cask.sourcefile_path, before_commit: commit_range)
return if previous_cask_contents.empty? return if previous_cask_contents.empty?
begin
previous_cask = CaskLoader.load_from_string(previous_cask_contents) previous_cask = CaskLoader.load_from_string(previous_cask_contents)
return unless previous_cask.version == cask.version return unless previous_cask.version == cask.version
return if previous_cask.sha256 == cask.sha256 return if previous_cask.sha256 == cask.sha256
add_error "only sha256 changed (see: https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/sha256.md)" add_error "only sha256 changed (see: https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/sha256.md)"
rescue CaskError => e
add_warning "Skipped version and checksum comparison. Reading previous version failed: #{e}"
end
end end
def check_version def check_version