admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

lines_cop: add missing e.g. clang++ regex SOL.

Browse Source 
You need a start of line check in this regex (like was added in the
others) to allow things like `#{bin}/clang++`.
This commit is contained in:
Mike McQuaid 2017-10-27 14:58:07 +01:00
parent 2be11f6040
commit d985838428
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/rubocops/lines_cop.rb
View File

@ -178,7 +178,7 @@ module RuboCop
param = parameters(method).first
if match = regex_match_group(param, %r{^(/usr/bin/)?(gcc|llvm-gcc|clang)\s?})
problem "Use \"\#{ENV.cc}\" instead of hard-coding \"#{match[2]}\""
elsif match = regex_match_group(param, %r{(/usr/bin/)?((g|llvm-g|clang)\+\+)\s?})
elsif match = regex_match_group(param, %r{^(/usr/bin/)?((g|llvm-g|clang)\+\+)\s?})
problem "Use \"\#{ENV.cxx}\" instead of hard-coding \"#{match[2]}\""
end
end