admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Fix SYMROOT audit

Browse Source
This commit is contained in:
Jack Nagel 2013-07-16 23:15:22 -05:00
parent f432a59fd0
commit d9790309a6
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Library/Homebrew/cmd/audit.rb
View File

@ -331,7 +331,14 @@ class FormulaAuditor
end end
end end
def audit_text(line) def audit_text
# xcodebuild should specify SYMROOT
if text=~ /system\s+['"]xcodebuild/ and not text =~ /SYMROOT=/
problem "xcodebuild should be passed an explicit \"SYMROOT\""
end
end
def audit_line(line)
if line =~ /<(Formula|AmazonWebServicesFormula|ScriptFileFormula|GithubGistFormula)/ if line =~ /<(Formula|AmazonWebServicesFormula|ScriptFileFormula|GithubGistFormula)/
problem "Use a space in class inheritance: class Foo < #{$1}" problem "Use a space in class inheritance: class Foo < #{$1}"
end end
@ -423,11 +430,6 @@ class FormulaAuditor
problem "Use spaces instead of tabs for indentation" problem "Use spaces instead of tabs for indentation"
end end
# xcodebuild should specify SYMROOT
if line =~ /system\s+['"]xcodebuild/ and not line =~ /SYMROOT=/
problem "xcodebuild should be passed an explicit \"SYMROOT\""
end
if line =~ /ENV\.x11/ if line =~ /ENV\.x11/
problem "Use \"depends_on :x11\" instead of \"ENV.x11\"" problem "Use \"depends_on :x11\" instead of \"ENV.x11\""
end end
@ -609,7 +611,8 @@ class FormulaAuditor
audit_deps audit_deps
audit_conflicts audit_conflicts
audit_patches audit_patches
text.each_line { |line| audit_text(line) } audit_text
text.each_line { |line| audit_line(line) }
audit_python audit_python
audit_installed audit_installed
end end