From d87f1fb5ec076498e66678e5f05c33026abdd96d Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Mon, 14 Oct 2013 21:46:21 -0500 Subject: [PATCH] Assert on state, not something that didn't happen --- .../Homebrew/test/test_formula_validation.rb | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/Library/Homebrew/test/test_formula_validation.rb b/Library/Homebrew/test/test_formula_validation.rb index 0bfff5ad2a..8adff7f295 100644 --- a/Library/Homebrew/test/test_formula_validation.rb +++ b/Library/Homebrew/test/test_formula_validation.rb @@ -55,22 +55,19 @@ class FormulaValidationTests < Test::Unit::TestCase end def test_devel_only_valid - assert_nothing_raised do - formula do - devel do - url "foo" - version "1.0" - end + f = formula do + devel do + url "foo" + version "1.0" end end + + assert_equal "foo", f.url end def test_head_only_valid - assert_nothing_raised do - formula do - head "foo" - end - end + f = formula { head "foo" } + assert_equal "foo", f.url end def test_empty_formula_invalid