admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Feedback changes and fix for pull_request join

Browse Source
This commit is contained in:
Baffour Adu Boampong 2020-07-21 17:09:53 +00:00
parent 076b4dd89f
commit d86c4d7b7a
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/dev-cmd/bump.rb
View File

@ -39,8 +39,8 @@ module Homebrew
next if repology_homebrew_repo.blank? next if repology_homebrew_repo.blank?
latest_version = repositories.find { |repo| repo["status"] == "newest" }["version"] latest_version = repositories.find { |repo| repo["status"] == "newest" }["version"]
srcname = repology_homebrew_repo["srcname"]
packages[repology_homebrew_repo["srcname"]] = format_package(repology_homebrew_repo["srcname"], latest_version) packages[srcname] = format_package(srcname, latest_version)
end end
packages packages
end end
@ -54,12 +54,13 @@ module Homebrew
current_version = current_formula_version(formula) current_version = current_formula_version(formula)
livecheck_response = livecheck_formula(package_name) livecheck_response = livecheck_formula(package_name)
pull_requests = GitHub.check_for_duplicate_pull_requests(formula, tap_full_name, latest_version) pull_requests = GitHub.check_for_duplicate_pull_requests(formula, tap_full_name, latest_version)
pull_requests = pull_requests.join(", ") if pull_requests.try(:any?)
{ {
repology_latest_version: latest_version, repology_latest_version: latest_version,
current_formula_version: current_version.to_s, current_formula_version: current_version.to_s,
livecheck_latest_version: livecheck_response[:livecheck_version], livecheck_latest_version: livecheck_response[:livecheck_version],
open_pull_requests: pull_requests.join(", "), open_pull_requests: pull_requests,
} }
end end
@ -82,6 +83,7 @@ module Homebrew
end end
def parse_livecheck_response(response) def parse_livecheck_response(response)
# e.g response => aacgain : 7834 ==> 1.8
output = response.delete(" ").split(/:|==>/) output = response.delete(" ").split(/:|==>/)
# e.g. ["openclonk", "7.0", "8.1"] # e.g. ["openclonk", "7.0", "8.1"]

4
Library/Homebrew/diagnostic.rb
View File

@ -671,9 +671,7 @@ module Homebrew
next if status.blank? next if status.blank?
# these will result in uncommitted gems. # these will result in uncommitted gems.
if path == HOMEBREW_REPOSITORY next if path == HOMEBREW_REPOSITORY && (ENV["HOMEBREW_SORBET"] || ENV["HOMEBREW_PATCHELF_RB"])
next if ENV["HOMEBREW_SORBET"] || ENV["HOMEBREW_PATCHELF_RB"]
end
message ||= "" message ||= ""
message += "\n" unless message.empty? message += "\n" unless message.empty?