From d7a479f55105f277ce96ad1b4385679c93618add Mon Sep 17 00:00:00 2001 From: Xu Cheng Date: Fri, 30 Oct 2015 14:44:43 +0800 Subject: [PATCH] JavaRequirement: check satisfaction directly It made less sense to call a method `java_version` when it returns boolean value. Closes Homebrew/homebrew#45501. Signed-off-by: Xu Cheng --- Library/Homebrew/requirements/java_requirement.rb | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/Library/Homebrew/requirements/java_requirement.rb b/Library/Homebrew/requirements/java_requirement.rb index 448ebb7e4a..93650d4136 100644 --- a/Library/Homebrew/requirements/java_requirement.rb +++ b/Library/Homebrew/requirements/java_requirement.rb @@ -5,7 +5,12 @@ class JavaRequirement < Requirement cask "java" download "http://www.oracle.com/technetwork/java/javase/downloads/index.html" - satisfy(:build_env => false) { java_version } + satisfy :build_env => false do + args = %w[--failfast] + args << "--version" << "#{@version}" if @version + @java_home = Utils.popen_read("/usr/libexec/java_home", *args).chomp + $?.success? + end env do java_home = Pathname.new(@java_home) @@ -24,13 +29,6 @@ class JavaRequirement < Requirement super end - def java_version - args = %w[--failfast] - args << "--version" << "#{@version}" if @version - @java_home = Utils.popen_read("/usr/libexec/java_home", *args).chomp - $?.success? - end - def message version_string = " #{@version}" if @version