Merge pull request #17241 from Homebrew/cask-audit-sourceforge

cask/audit: tune sourceforge.net URL regex

Library/Homebrew/cask/audit.rb

@@ -868,7 +868,7 @@ module Cask
 
     sig { returns(T::Boolean) }
     def bad_sourceforge_url?
-      bad_url_format?(/sourceforge/,
+      bad_url_format?(%r{((downloads|\.dl)\.|//)sourceforge},
                       [
                         %r{\Ahttps://sourceforge\.net/projects/[^/]+/files/latest/download\Z},
                         %r{\Ahttps://downloads\.sourceforge\.net/(?!(project|sourceforge)/)},

Library/Homebrew/rubocops/urls.rb

@@ -143,10 +143,7 @@ module RuboCop
             end
 
             if url.match?(%r{^https?://prdownloads\.})
-              problem <<~EOS.chomp
-                Don't use prdownloads in SourceForge urls (url is #{url}).
-                        See: http://librelist.com/browser/homebrew/2011/1/12/prdownloads-is-bad/
-              EOS
+              problem "Don't use prdownloads in SourceForge urls (url is #{url})."
             end
 
             if url.match?(%r{^http://\w+\.dl\.})

Library/Homebrew/test/rubocops/urls_spec.rb

@@ -63,10 +63,8 @@ RSpec.describe RuboCop::Cop::FormulaAudit::Urls do
       "col" => 2,
     }, {
       "url" => "http://prdownloads.sourceforge.net/foo/foo-1.tar.gz",
-      "msg" => <<~EOS.chomp,
-        Don't use prdownloads in SourceForge urls (url is http://prdownloads.sourceforge.net/foo/foo-1.tar.gz).
-                See: http://librelist.com/browser/homebrew/2011/1/12/prdownloads-is-bad/
-      EOS
+      "msg" => "Don't use prdownloads in SourceForge urls " \
+               "(url is http://prdownloads.sourceforge.net/foo/foo-1.tar.gz).",
       "col" => 2,
     }, {
       "url" => "http://foo.dl.sourceforge.net/sourceforge/foozip/foozip_1.0.tar.bz2",