admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #17241 from Homebrew/cask-audit-sourceforge

Browse Source 
cask/audit: tune sourceforge.net URL regex
This commit is contained in:
Mike McQuaid 2024-05-07 09:06:50 +01:00 committed by GitHub
commit d77dbe8b89
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/cask/audit.rb
View File

@ -868,7 +868,7 @@ module Cask
sig { returns(T::Boolean) } sig { returns(T::Boolean) }
def bad_sourceforge_url? def bad_sourceforge_url?
bad_url_format?(/sourceforge/, bad_url_format?(%r{((downloads|\.dl)\.|//)sourceforge},
[ [
%r{\Ahttps://sourceforge\.net/projects/[^/]+/files/latest/download\Z}, %r{\Ahttps://sourceforge\.net/projects/[^/]+/files/latest/download\Z},
%r{\Ahttps://downloads\.sourceforge\.net/(?!(project|sourceforge)/)}, %r{\Ahttps://downloads\.sourceforge\.net/(?!(project|sourceforge)/)},

5
Library/Homebrew/rubocops/urls.rb
View File

@ -143,10 +143,7 @@ module RuboCop
end end
if url.match?(%r{^https?://prdownloads\.}) if url.match?(%r{^https?://prdownloads\.})
problem <<~EOS.chomp problem "Don't use prdownloads in SourceForge urls (url is #{url})."
Don't use prdownloads in SourceForge urls (url is #{url}).
See: http://librelist.com/browser/homebrew/2011/1/12/prdownloads-is-bad/
EOS
end end
if url.match?(%r{^http://\w+\.dl\.}) if url.match?(%r{^http://\w+\.dl\.})

6
Library/Homebrew/test/rubocops/urls_spec.rb
View File

@ -63,10 +63,8 @@ RSpec.describe RuboCop::Cop::FormulaAudit::Urls do
"col" => 2, "col" => 2,
}, { }, {
"url" => "http://prdownloads.sourceforge.net/foo/foo-1.tar.gz", "url" => "http://prdownloads.sourceforge.net/foo/foo-1.tar.gz",
"msg" => <<~EOS.chomp, "msg" => "Don't use prdownloads in SourceForge urls " \
Don't use prdownloads in SourceForge urls (url is http://prdownloads.sourceforge.net/foo/foo-1.tar.gz). "(url is http://prdownloads.sourceforge.net/foo/foo-1.tar.gz).",
See: http://librelist.com/browser/homebrew/2011/1/12/prdownloads-is-bad/
EOS
"col" => 2, "col" => 2,
}, { }, {
"url" => "http://foo.dl.sourceforge.net/sourceforge/foozip/foozip_1.0.tar.bz2", "url" => "http://foo.dl.sourceforge.net/sourceforge/foozip/foozip_1.0.tar.bz2",