admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

bottle: avoid keeping entire strings output in memory

Browse Source
This commit is contained in:
Jack Nagel 2013-12-14 15:43:15 -06:00
parent d7c13f84b6
commit d75577a239
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Library/Homebrew/cmd/bottle.rb
View File

@ -86,12 +86,17 @@ module Homebrew extend self
end end
# Use strings to search through the file for each string # Use strings to search through the file for each string
strings = `strings -t x - "#{file}"`.split("\n").select{ |str| str.include? string } IO.popen("strings -t x - '#{file}'") do |io|
until io.eof?
str = io.readline.chomp
strings.each do |str| next unless str.include? string
offset, match = str.split(" ", 2)
next if linked_libraries.include? match # Don't bother reporting a string if it was found by otool offset, match = str.split(" ", 2)
puts " #{Tty.gray}-->#{Tty.reset} match '#{match}' at offset #{Tty.em}0x#{offset}#{Tty.reset}"
next if linked_libraries.include? match # Don't bother reporting a string if it was found by otool
puts " #{Tty.gray}-->#{Tty.reset} match '#{match}' at offset #{Tty.em}0x#{offset}#{Tty.reset}"
end
end end
end end
puts puts