admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Make the regex for URL checking more git friendly

Browse Source 
* Urls for Git Commits need to be between 4-40 not 40.

For example:

https://github.com/mxcl/homebrew/commit/805a
https://github.com/mxcl/homebrew/commit/805

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This commit is contained in:
Lee Packham 2010-11-20 23:11:27 +00:00 committed by Mike McQuaid
parent 5733fce6fc
commit d5c58f889a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Contributions/examples/brew-pull.rb
View File

@ -16,7 +16,7 @@ end
HOMEBREW_REPOSITORY.cd do
ARGV.each do|arg|
# This regex should work, if it's too precise, feel free to fix it.
if !arg.match 'https:\/\/github.com\/\w+\/homebrew\/(pull\/\d+|commit\/\w{40})'
if !arg.match 'https:\/\/github.com\/\w+\/homebrew\/(pull\/\d+|commit\/\w{4,40})'
ohai 'Ignoring URL:', "Not a GitHub pull request or commit: #{arg}"
next
end