admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: imporve revision check logic

Browse Source 
* Check revision decrease against both stable and devel spec.
* Check revision reset only for stable spec if stable spec is available.
This commit is contained in:
Xu Cheng 2016-01-15 16:17:14 +08:00
parent 176f345386
commit d4c7dedf12
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/cmd/audit.rb
View File

@ -588,8 +588,14 @@ class FormulaAuditor
revision_map = fv.revision_map("origin/master") revision_map = fv.revision_map("origin/master")
if (revisions = revision_map[formula.version]).any? if (revisions = revision_map[formula.version]).any?
problem "revision should not decrease" if formula.revision < revisions.max problem "revision should not decrease" if formula.revision < revisions.max
else elsif formula.revision != 0
problem "revision should be removed" unless formula.revision == 0 if formula.stable
if revision_map[formula.stable.version].empty? # check stable spec
problem "revision should be removed"
end
else # head/devel-only formula
problem "revision should be removed"
end
end end
end end