From d3eac3848e9028fdb7292796305b8ed103db7f91 Mon Sep 17 00:00:00 2001 From: Sam Ford <1584702+samford@users.noreply.github.com> Date: Sun, 2 Jun 2024 22:52:58 -0400 Subject: [PATCH] Curl#curl_headers: Work with 8 exit_status I recently noticed that ~23 `livecheck` blocks using the `HeaderMatch` strategy were failing. Looking into it, these fail when using a `HEAD` request and retry with `GET` but the resulting response with the headers we want is simply discarded because the `exit_status` from curl is 8 ("weird server reply"). This resolves the issue by adding a special case for this exit status, so `#curl_headers` will return the headers in this scenario. --- Library/Homebrew/utils/curl.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/utils/curl.rb b/Library/Homebrew/utils/curl.rb index 4b3389f6a8..592b9eb9da 100644 --- a/Library/Homebrew/utils/curl.rb +++ b/Library/Homebrew/utils/curl.rb @@ -223,7 +223,7 @@ module Utils ) # 22 means a non-successful HTTP status code, not a `curl` error, so we still got some headers. - if result.success? || result.exit_status == 22 + if result.success? || result.exit_status == 8 || result.exit_status == 22 parsed_output = parse_curl_output(result.stdout) if request_args.empty? @@ -235,7 +235,7 @@ module Utils next if (400..499).cover?(parsed_output.fetch(:responses).last&.fetch(:status_code).to_i) end - return parsed_output if result.success? + return parsed_output if result.success? || result.exit_status == 8 end result.assert_success!