admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Curl#curl_headers: Work with 8 exit_status

Browse Source 
I recently noticed that ~23 `livecheck` blocks using the `HeaderMatch`
strategy were failing. Looking into it, these fail when using a `HEAD`
request and retry with `GET` but the resulting response with the
headers we want is simply discarded because the `exit_status` from
curl is 8 ("weird server reply").

This resolves the issue by adding a special case for this exit status,
so `#curl_headers` will return the headers in this scenario.
This commit is contained in:
Sam Ford 2024-06-02 22:52:58 -04:00
parent 4814f4512d
commit d3eac3848e
No known key found for this signature in database
GPG Key ID: 7AF5CBEE1DD6F76D
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/utils/curl.rb
View File

@ -223,7 +223,7 @@ module Utils
)
# 22 means a non-successful HTTP status code, not a `curl` error, so we still got some headers.
if result.success? || result.exit_status == 22
if result.success? || result.exit_status == 8 || result.exit_status == 22
parsed_output = parse_curl_output(result.stdout)
if request_args.empty?
@ -235,7 +235,7 @@ module Utils
next if (400..499).cover?(parsed_output.fetch(:responses).last&.fetch(:status_code).to_i)
end
return parsed_output if result.success?
return parsed_output if result.success? || result.exit_status == 8
end
result.assert_success!