admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

fix tests

Browse Source
This commit is contained in:
Bevan Kay 2022-01-12 10:39:38 +11:00
parent 6f62b0e029
commit d371547d5a
No known key found for this signature in database
GPG Key ID: C55CB024B5314B57
2 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/rubocops/cask/url_legacy_comma_separators.rb
View File

@ -13,7 +13,7 @@ module RuboCop
extend AutoCorrector extend AutoCorrector
MSG_CSV = "Use 'version.csv.first' instead of 'version.before_comma' " \ MSG_CSV = "Use 'version.csv.first' instead of 'version.before_comma' " \
"and 'version.csv.second' instead of 'version.after_comma'." "and 'version.csv.second' instead of 'version.after_comma'"
def on_url_stanza(stanza) def on_url_stanza(stanza)
return if stanza.stanza_node.type == :block return if stanza.stanza_node.type == :block

32
Library/Homebrew/test/rubocops/cask/url_legacy_comma_separators_spec.rb
View File

@ -14,7 +14,7 @@ describe RuboCop::Cop::Cask::UrlLegacyCommaSeparators do
<<-CASK.undent <<-CASK.undent
cask 'foo' do cask 'foo' do
version '1.1' version '1.1'
url 'https://foo.brew.sh/foo-#{version}.dmg' url 'https://foo.brew.sh/foo-\#{version}.dmg'
end end
CASK CASK
end end
@ -27,7 +27,7 @@ describe RuboCop::Cop::Cask::UrlLegacyCommaSeparators do
<<-CASK.undent <<-CASK.undent
cask 'foo' do cask 'foo' do
version '1.1,111' version '1.1,111'
url 'https://foo.brew.sh/foo-#{version.csv.first}.dmg' url 'https://foo.brew.sh/foo-\#{version.csv.first}.dmg'
end end
CASK CASK
end end
@ -40,7 +40,7 @@ describe RuboCop::Cop::Cask::UrlLegacyCommaSeparators do
<<-CASK.undent <<-CASK.undent
cask 'foo' do cask 'foo' do
version '1.1,111' version '1.1,111'
url 'https://foo.brew.sh/foo-#{version.before_comma}.dmg' url 'https://foo.brew.sh/foo-\#{version.before_comma}.dmg'
end end
CASK CASK
end end
@ -48,18 +48,18 @@ describe RuboCop::Cop::Cask::UrlLegacyCommaSeparators do
<<-CASK.undent <<-CASK.undent
cask 'foo' do cask 'foo' do
version '1.1,111' version '1.1,111'
url 'https://foo.brew.sh/foo-#{version.csv.first}.dmg' url 'https://foo.brew.sh/foo-\#{version.csv.first}.dmg'
end end
CASK CASK
end end
let(:expected_offenses) do let(:expected_offenses) do
[{ [{
message: "'https://foo.brew.sh/foo-#{version.before_comma}.dmg' should use "\ message: "Use 'version.csv.first' instead of 'version.before_comma' "\
"#{version.csv.first} instead of #{version.before_comma}.'", "and 'version.csv.second' instead of 'version.after_comma'",
severity: :convention, severity: :convention,
line: 2, line: 3,
column: 11, column: 6,
source: "'https://foo.brew.sh/foo-#{version.before_comma}.dmg'", source: "'https://foo.brew.sh/foo-\#{version.before_comma}.dmg'",
}] }]
end end
@ -73,7 +73,7 @@ describe RuboCop::Cop::Cask::UrlLegacyCommaSeparators do
<<-CASK.undent <<-CASK.undent
cask 'foo' do cask 'foo' do
version '1.1,111' version '1.1,111'
url 'https://foo.brew.sh/foo-#{version.after_comma}.dmg' url 'https://foo.brew.sh/foo-\#{version.after_comma}.dmg'
end end
CASK CASK
end end
@ -81,18 +81,18 @@ describe RuboCop::Cop::Cask::UrlLegacyCommaSeparators do
<<-CASK.undent <<-CASK.undent
cask 'foo' do cask 'foo' do
version '1.1,111' version '1.1,111'
url 'https://foo.brew.sh/foo-#{version.csv.second}.dmg' url 'https://foo.brew.sh/foo-\#{version.csv.second}.dmg'
end end
CASK CASK
end end
let(:expected_offenses) do let(:expected_offenses) do
[{ [{
message: "'https://foo.brew.sh/foo-#{version.after_comma}.dmg' should use "\ message: "Use 'version.csv.first' instead of 'version.before_comma' "\
"#{version.csv.second} instead of #{version.after_comma}.'", "and 'version.csv.second' instead of 'version.after_comma'",
severity: :convention, severity: :convention,
line: 2, line: 3,
column: 11, column: 6,
source: "'https://foo.brew.sh/foo-#{version.after_comma}.dmg'", source: "'https://foo.brew.sh/foo-\#{version.after_comma}.dmg'",
}] }]
end end