admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

github_latest: modify strategy and tests

Browse Source
This commit is contained in:
nandahkrishna 2020-12-05 20:35:01 +05:30
parent f96b8e7138
commit d173b57c42
No known key found for this signature in database
GPG Key ID: 067E5FCD58ADF3AA
2 changed files with 21 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/livecheck/strategy/github_latest.rb
View File

@ -7,10 +7,11 @@ module Homebrew
# The {GithubLatest} strategy identifies versions of software at
# github.com by checking a repository's latest release page.
#
# GitHub URLs take a few differemt formats:
# GitHub URLs take a few different formats:
#
# * `https://github.com/example/example/releases/download/1.2.3/example-1.2.3.zip`
# * `https://github.com/example/example/releases/download/1.2.3/example-1.2.3.tar.gz`
# * `https://github.com/example/example/archive/v1.2.3.tar.gz`
# * `https://github.com/downloads/example/example/example-1.2.3.tar.gz`
#
# This strategy is used when latest releases are marked for software hosted
# on GitHub. It is necessary to use `strategy :github_latest` in a `livecheck`
@ -21,10 +22,12 @@ module Homebrew
#
# @api public
class GithubLatest
NICE_NAME = "GitHub Latest"
NICE_NAME = "GitHub - Latest"
PRIORITY = 0
# The `Regexp` used to determine if the strategy applies to the URL.
URL_MATCH_REGEX = /github.com/i.freeze
URL_MATCH_REGEX = %r{//github\.com(?:/downloads)?(?:/[^/]+){2}}i.freeze
# Whether the strategy can be applied to the provided URL.
#
@ -41,7 +44,7 @@ module Homebrew
# @param regex [Regexp] a regex used for matching versions in content
# @return [Hash]
def self.find_versions(url, regex = nil)
%r{github\.com/(?<username>[\da-z\-]+)/(?<repository>[\da-z_\-]+)}i =~ url
%r{github\.com/(?:downloads/)?(?<username>[^/]+)/(?<repository>[^/]+)}i =~ url.sub(/\.git$/i, "")
# The page containing the latest release
page_url = "https://github.com/#{username}/#{repository}/releases/latest"

19
Library/Homebrew/test/livecheck/strategy/github_latest_spec.rb
View File

@ -6,17 +6,24 @@ require "livecheck/strategy/github_latest"
describe Homebrew::Livecheck::Strategy::GithubLatest do
subject(:github_latest) { described_class }
let(:github_download_url) { "https://github.com/example/example/releases/download/1.2.3/example-1.2.3.zip" }
let(:github_archive_url) { "https://github.com/example/example/archive/v1.2.3.tar.gz" }
let(:github_release_artifact_url) {
"https://github.com/example/example/releases/download/1.2.3/example-1.2.3.zip"
}
let(:github_tag_archive_url) { "https://github.com/example/example/archive/v1.2.3.tar.gz" }
let(:github_repository_upload_url) { "https://github.com/downloads/example/example/example-1.2.3.tar.gz" }
let(:non_github_url) { "https://brew.sh/test" }
describe "::match?" do
it "returns true if the argument provided is a GitHub Download URL" do
expect(github_latest.match?(github_download_url)).to be true
it "returns true if the argument provided is a GitHub release artifact URL" do
expect(github_latest.match?(github_release_artifact_url)).to be true
end
it "returns true if the argument provided is a GitHub Archive URL" do
expect(github_latest.match?(github_archive_url)).to be true
it "returns true if the argument provided is a GitHub tag archive URL" do
expect(github_latest.match?(github_tag_archive_url)).to be true
end
it "returns true if the argument provided is a GitHub repository upload URL" do
expect(github_latest.match?(github_repository_upload_url)).to be true
end
it "returns false if the argument provided is not a GitHub URL" do