admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

brew.sh: fix some stderr redirections to /dev/null

Browse Source 
The order matters here (in a way that I can't explain, unfortunately).

Example:

    bash-3.2$ read -r FOO <nonexistent 2>/dev/null
    bash: nonexistent: No such file or directory

    bash-3.2$ read -r FOO 2>/dev/null <nonexistent
    # no output

Fixes Homebrew/discussions#5653.
This commit is contained in:
Carlo Cabrera 2024-10-04 16:34:55 +08:00
parent 4671af4bb9
commit d14accee39
No known key found for this signature in database
GPG Key ID: C74D447FC549A1D0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/brew.sh
View File

@ -445,13 +445,13 @@ GIT_REVISION=$("${HOMEBREW_GIT}" -C "${HOMEBREW_REPOSITORY}" rev-parse HEAD 2>/d
# safe fallback in case git rev-parse fails e.g. if this is not considered a safe git directory
if [[ -z "${GIT_REVISION}" ]]
then
read -r GIT_HEAD <"${HOMEBREW_REPOSITORY}/.git/HEAD" 2>/dev/null
read -r GIT_HEAD 2>/dev/null <"${HOMEBREW_REPOSITORY}/.git/HEAD"
if [[ "${GIT_HEAD}" == "ref: refs/heads/master" ]]
then
read -r GIT_REVISION <"${HOMEBREW_REPOSITORY}/.git/refs/heads/master" 2>/dev/null
read -r GIT_REVISION 2>/dev/null <"${HOMEBREW_REPOSITORY}/.git/refs/heads/master"
elif [[ "${GIT_HEAD}" == "ref: refs/heads/stable" ]]
then
read -r GIT_REVISION <"${HOMEBREW_REPOSITORY}/.git/refs/heads/stable" 2>/dev/null
read -r GIT_REVISION 2>/dev/null <"${HOMEBREW_REPOSITORY}/.git/refs/heads/stable"
fi
unset GIT_HEAD
fi