admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #9305 from jonchang/check-tap-branches

Browse Source 
diagnostic: check all tap branches, not just core
This commit is contained in:
Jonathan Chang 2020-11-27 17:04:05 +11:00 committed by GitHub
commit d1295ae443
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
Library/Homebrew/diagnostic.rb
View File

@ -566,20 +566,30 @@ module Homebrew
examine_git_origin(cask_tap.path, cask_tap.remote)
end
def check_coretap_git_branch
sig { returns(T.nilable(String)) }
def check_tap_git_branch
return if ENV["CI"]
return unless Utils::Git.available?
coretap_path = CoreTap.instance.path
return if !Utils::Git.available? || !(coretap_path/".git").exist?
commands = Tap.map do |tap|
next unless tap.path.git?
next if tap.path.git_origin.blank?
branch = coretap_path.git_branch
return if branch.blank? || branch.include?("master")
branch = tap.path.git_branch
next if branch.blank?
origin_branch = Utils::Git.origin_branch(tap.path)&.split("/")&.last
next if origin_branch == branch
"git -C $(brew --repo #{tap.name}) checkout #{origin_branch}"
end.compact
return if commands.blank?
<<~EOS
#{CoreTap.instance.full_name} is not on the master branch.
Check out the master branch by running:
git -C "$(brew --repo homebrew/core)" checkout master
Some taps are not on the default git origin branch and may not receive
updates. If this is a surprise to you, check out the default branch with:
#{commands.join("\n ")}
EOS
end