admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

bottle: use key/value rather than field.

Browse Source 
Consistent naming is good.
This commit is contained in:
Mike McQuaid 2016-09-10 19:43:49 +01:00
parent 7fb915319d
commit d0c33b3705
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Library/Homebrew/dev-cmd/bottle.rb
View File

@ -289,17 +289,17 @@ module Homebrew
old_spec = f.bottle_specification old_spec = f.bottle_specification
if ARGV.include?("--keep-old") && !old_spec.checksums.empty? if ARGV.include?("--keep-old") && !old_spec.checksums.empty?
mismatches = [:root_url, :prefix, :cellar, :rebuild].select do |field| mismatches = [:root_url, :prefix, :cellar, :rebuild].select do |key|
old_spec.send(field) != bottle.send(field) old_spec.send(key) != bottle.send(key)
end end
mismatches.delete(:cellar) if old_spec.cellar == :any && bottle.cellar == :any_skip_relocation mismatches.delete(:cellar) if old_spec.cellar == :any && bottle.cellar == :any_skip_relocation
unless mismatches.empty? unless mismatches.empty?
bottle_path.unlink if bottle_path.exist? bottle_path.unlink if bottle_path.exist?
mismatches.map! do |field| mismatches.map! do |key|
old_value = old_spec.send(field).inspect old_value = old_spec.send(key).inspect
value = bottle.send(field).inspect value = bottle.send(key).inspect
"#{field}: old: #{old_value}, new: #{value}" "#{key}: old: #{old_value}, new: #{value}"
end end
odie <<-EOS.undent odie <<-EOS.undent
@ -405,7 +405,7 @@ module Homebrew
if old_value.empty? || value != old_value if old_value.empty? || value != old_value
old_value = old_value_original.inspect old_value = old_value_original.inspect
value = value_original.inspect value = value_original.inspect
mismatches << "#{field}: old: #{old_value}, new: #{value}" mismatches << "#{key}: old: #{old_value}, new: #{value}"
end end
end end