Don't mutate the tab object

2014-06-29 23:15:13 -05:00 · 2014-06-29 23:15:13 -05:00 · d083efdbda
commit d083efdbda
parent ac687d3b5f
1 changed files with 3 additions and 3 deletions
--- a/Library/Homebrew/tab.rb
+++ b/Library/Homebrew/tab.rb
@ -31,9 +31,9 @@ class Tab < OpenStruct
  end

  def self.from_file path
-    tab = Tab.new Utils::JSON.load(File.read(path))
-    tab.tabfile = path
-    tab
+    attributes = Utils::JSON.load(File.read(path))
+    attributes[:tabfile] = path
+    new(attributes)
  end

  def self.for_keg keg