admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

SkipConditions: use versioned URLs in test casks

Browse Source 
The `Cask::Cask` objects in the `SkipConditions` tests don't
interpolate `version` in the `url` strings, so these are technically
unversioned URLs as a result and would be skipped as unversioned. This
updates the URLs accordingly, so they won't trigger the unversioned
skip as a fallback (if the intended test doesn't work as expected).
This is something I discovered while writing a test for a cask that
shouldn't be skipped.
This commit is contained in:
Sam Ford 2025-08-03 10:25:43 -04:00
parent ff2b1d6821
commit d06480aae1
No known key found for this signature in database
GPG Key ID: 7AF5CBEE1DD6F76D
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Library/Homebrew/test/livecheck/skip_conditions_spec.rb
View File

@ -82,7 +82,7 @@ RSpec.describe Homebrew::Livecheck::SkipConditions do
basic: Cask::Cask.new("test") do
version "0.0.1,2"
url "https://brew.sh/test-0.0.1.tgz"
url "https://brew.sh/test-#{version.csv.first}.tgz"
name "Test"
desc "Test cask"
homepage "https://brew.sh"
@ -96,7 +96,7 @@ RSpec.describe Homebrew::Livecheck::SkipConditions do
version "0.0.1"
sha256 :no_check
url "https://brew.sh/test-0.0.1.tgz"
url "https://brew.sh/test-#{version}.tgz"
name "Test Deprecate"
desc "Deprecated test cask"
homepage "https://brew.sh"
@ -107,7 +107,7 @@ RSpec.describe Homebrew::Livecheck::SkipConditions do
version "0.0.1"
sha256 :no_check
url "https://brew.sh/test-0.0.1.tgz"
url "https://brew.sh/test-#{version}.tgz"
name "Test Disable"
desc "Disabled test cask"
homepage "https://brew.sh"
@ -127,7 +127,7 @@ RSpec.describe Homebrew::Livecheck::SkipConditions do
extract_plist: Cask::Cask.new("test_extract_plist_skip") do
version "0.0.1"
url "https://brew.sh/test-0.0.1.tgz"
url "https://brew.sh/test-#{version}.tgz"
name "Test ExtractPlist Skip"
desc "Skipped test cask"
homepage "https://brew.sh"
@ -157,7 +157,7 @@ RSpec.describe Homebrew::Livecheck::SkipConditions do
skip: Cask::Cask.new("test_skip") do
version "0.0.1"
url "https://brew.sh/test-0.0.1.tgz"
url "https://brew.sh/test-#{version}.tgz"
name "Test Skip"
desc "Skipped test cask"
homepage "https://brew.sh"
@ -169,7 +169,7 @@ RSpec.describe Homebrew::Livecheck::SkipConditions do
skip_with_message: Cask::Cask.new("test_skip_with_message") do
version "0.0.1"
url "https://brew.sh/test-0.0.1.tgz"
url "https://brew.sh/test-#{version}.tgz"
name "Test Skip"
desc "Skipped test cask"
homepage "https://brew.sh"