admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Maintainer-Guidelines: add sjackman CI test note.

Browse Source
This commit is contained in:
Mike McQuaid 2018-12-17 15:55:06 +00:00
parent 3245b91900
commit cf391ef160
No known key found for this signature in database
GPG Key ID: 48A898132FD8EE70
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/Maintainer-Guidelines.md
View File

@ -88,7 +88,10 @@ implemented!).
Don't merge any formula updates with failing `brew test`s. If a `test do` block Don't merge any formula updates with failing `brew test`s. If a `test do` block
is failing it needs to be fixed. This may involve replacing more involved tests is failing it needs to be fixed. This may involve replacing more involved tests
with those that are more reliable. This is fine: false positives are better than with those that are more reliable. This is fine: false positives are better than
false negatives as we don't want to teach maintainers to merge red PRs. false negatives as we don't want to teach maintainers to merge red PRs. If the
test failure is believed to be due to a bug in Homebrew/brew or the CI system,
that bug must be fixed, or worked around in the formula to yield a passing test,
before the PR can be merged.
## Common “gotchas” ## Common “gotchas”
1. [Ensure you have set your username and email address 1. [Ensure you have set your username and email address