diff --git a/Library/Homebrew/rubocops/text.rb b/Library/Homebrew/rubocops/text.rb index b61f25010f..866f1d4e21 100644 --- a/Library/Homebrew/rubocops/text.rb +++ b/Library/Homebrew/rubocops/text.rb @@ -53,12 +53,6 @@ module RuboCop problem "\"Formula.factory(name)\" is deprecated in favor of \"Formula[name]\"" end - find_every_method_call_by_name(body_node, :xcodebuild).each do |m| - next if parameters_passed?(m, /SYMROOT=/) - - problem 'xcodebuild should be passed an explicit "SYMROOT"' - end - find_method_with_args(body_node, :system, "xcodebuild") do problem %q(use "xcodebuild *args" instead of "system 'xcodebuild', *args") end diff --git a/Library/Homebrew/test/rubocops/text_spec.rb b/Library/Homebrew/test/rubocops/text_spec.rb index 1a20ca69d7..b8ae63dbd1 100644 --- a/Library/Homebrew/test/rubocops/text_spec.rb +++ b/Library/Homebrew/test/rubocops/text_spec.rb @@ -71,32 +71,6 @@ describe RuboCop::Cop::FormulaAudit::Text do RUBY end - it "reports an offense if xcodebuild is called without SYMROOT" do - expect_offense(<<~RUBY) - class Foo < Formula - url "https://brew.sh/foo-1.0.tgz" - homepage "https://brew.sh" - - def install - xcodebuild "-project", "meow.xcodeproject" - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ xcodebuild should be passed an explicit \"SYMROOT\" - end - end - RUBY - - expect_offense(<<~RUBY) - class Foo < Formula - url "https://brew.sh/foo-1.0.tgz" - homepage "https://brew.sh" - - def install - xcodebuild - ^^^^^^^^^^ xcodebuild should be passed an explicit \"SYMROOT\" - end - end - RUBY - end - it "reports an offense if `go get` is executed" do expect_offense(<<~RUBY) class Foo < Formula