From ab614ed4ce0879e1bb74cc09413b1599c991eff7 Mon Sep 17 00:00:00 2001 From: Liyang HU Date: Sat, 6 Mar 2021 20:45:27 +0000 Subject: [PATCH 1/2] -Library/Homebrew/shims/mac/super/sed: causes more problems than what it purports to fix Mountain Lion isn't even supported by Homebrew anymore. This shim hails back to Homebrew/legacy-homebrew#13787 @MikeMcQuaid This gets picked up by `configure` scripts (which is fine during builds), but occasionally gets [baked into binaries][fixincl], triggering: Error: Files were found with references to the Homebrew shims directory. This in turn causes tap maintainers to just override `SED=/usr/bin/sed` for `configure`, which doesn't always work properly: osx-cross/homebrew-avr#230 Other instances: * https://stackoverflow.com/questions/40357246/usr-local-library-homebrew-shims-super-sed-no-such-file-or-directory * https://github.com/laruence/yaconf/issues/17 * https://github.com/Amar1729/homebrew-formulae/issues/1 * https://blog.logical-dice.com/articles/wp/295 [fixincl]: https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=fixincludes/fixincl.tpl;h=3d70cabc7fd6dd0e63033e6523fac1dca01b285a;hb=HEAD#l42 --- Library/Homebrew/shims/mac/super/sed | 9 --------- 1 file changed, 9 deletions(-) delete mode 100755 Library/Homebrew/shims/mac/super/sed diff --git a/Library/Homebrew/shims/mac/super/sed b/Library/Homebrew/shims/mac/super/sed deleted file mode 100755 index 7b1313dac0..0000000000 --- a/Library/Homebrew/shims/mac/super/sed +++ /dev/null @@ -1,9 +0,0 @@ -#!/bin/bash - -if [[ "$HOMEBREW_CCCFG" = *s* ]] -then - # Fix issue with sed barfing on unicode characters on Mountain Lion - unset LC_ALL - export LC_CTYPE="C" -fi -exec /usr/bin/sed "$@" From adac92b32601d76b53fd111701f2359d53542e38 Mon Sep 17 00:00:00 2001 From: Liyang HU Date: Sat, 6 Mar 2021 22:51:21 +0000 Subject: [PATCH 2/2] Library/Homebrew/extend/os/mac/extend/ENV/super.rb: obsolete HOMEBREW_CCCFG flag `s` @Bo98's comment https://github.com/Homebrew/brew/pull/10802#issuecomment-792072121 --- Library/Homebrew/extend/os/mac/extend/ENV/super.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/Library/Homebrew/extend/os/mac/extend/ENV/super.rb b/Library/Homebrew/extend/os/mac/extend/ENV/super.rb index 456a985239..e58a10e577 100644 --- a/Library/Homebrew/extend/os/mac/extend/ENV/super.rb +++ b/Library/Homebrew/extend/os/mac/extend/ENV/super.rb @@ -98,8 +98,6 @@ module Superenv def determine_cccfg s = +"" - # Fix issue with sed barfing on unicode characters on Mountain Lion - s << "s" # Fix issue with >= Mountain Lion apr-1-config having broken paths s << "a" s.freeze