admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Remove "--fresh" option from installer

Browse Source 
Turns out that this doesn't really work at all. `brew install` _never_
reuses options in the first place, and using this option with `brew
upgrade` results in some nasty corner cases in passing options to
dependencies.
This commit is contained in:
Jack Nagel 2014-03-08 19:08:47 -06:00
parent cf41bb1ebb
commit ce93c75f11
4 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Contributions/manpages/brew.1.md
View File

@ -153,7 +153,7 @@ Note that these flags should only appear after a command.
Print a JSON representation of <formula>. Currently the only accepted value Print a JSON representation of <formula>. Currently the only accepted value
for <version> is `v1`. for <version> is `v1`.
* `install [--debug] [--env=<std|super>] [--ignore-dependencies] [--only-dependencies] [--fresh] [--cc=<compiler>] [--build-from-source] [--devel|--HEAD]` <formula>: * `install [--debug] [--env=<std|super>] [--ignore-dependencies] [--only-dependencies] [--cc=<compiler>] [--build-from-source] [--devel|--HEAD]` <formula>:
Install <formula>. Install <formula>.
<formula> is usually the name of the formula to install, but it can be specified <formula> is usually the name of the formula to install, but it can be specified
@ -175,9 +175,6 @@ Note that these flags should only appear after a command.
If `--only-dependencies` is passed, install the dependencies with specified If `--only-dependencies` is passed, install the dependencies with specified
options but do not install the specified formula. options but do not install the specified formula.
If `--fresh` is passed, the installation process will not re-use any
options from previous installs.
If `--cc=<compiler>` is passed, attempt to compile using <compiler>. If `--cc=<compiler>` is passed, attempt to compile using <compiler>.
<compiler> should be the name of the compiler's executable, for instance <compiler> should be the name of the compiler's executable, for instance
`gcc-4.2` for Apple's GCC 4.2, or `gcc-4.8` for a Homebrew-provided GCC `gcc-4.2` for Apple's GCC 4.2, or `gcc-4.8` for a Homebrew-provided GCC

1
Library/Homebrew/extend/ARGV.rb
View File

@ -187,7 +187,6 @@ module HomebrewArgvExtension
--build-bottle --build-bottle
--debug -d --debug -d
--devel --devel
--fresh
--interactive -i --interactive -i
--HEAD --HEAD
] ]

2
Library/Homebrew/formula_installer.rb
View File

@ -394,7 +394,7 @@ class FormulaInstaller
def build_argv def build_argv
opts = Options.coerce(sanitized_ARGV_options) opts = Options.coerce(sanitized_ARGV_options)
opts.concat(options) unless opts.include? "--fresh" opts.concat(options)
opts << Option.new("--build-from-source") # don't download bottle opts << Option.new("--build-from-source") # don't download bottle
end end

5
share/man/man1/brew.1
View File

@ -174,7 +174,7 @@ To view formula history locally: \fBbrew log \-p <formula>\fR\.
Print a JSON representation of \fIformula\fR\. Currently the only accepted value for \fIversion\fR is \fBv1\fR\. Print a JSON representation of \fIformula\fR\. Currently the only accepted value for \fIversion\fR is \fBv1\fR\.
. .
.TP .TP
\fBinstall [\-\-debug] [\-\-env=<std|super>] [\-\-ignore\-dependencies] [\-\-only\-dependencies] [\-\-fresh] [\-\-cc=<compiler>] [\-\-build\-from\-source] [\-\-devel|\-\-HEAD]\fR \fIformula\fR \fBinstall [\-\-debug] [\-\-env=<std|super>] [\-\-ignore\-dependencies] [\-\-only\-dependencies] [\-\-cc=<compiler>] [\-\-build\-from\-source] [\-\-devel|\-\-HEAD]\fR \fIformula\fR
Install \fIformula\fR\. Install \fIformula\fR\.
. .
.IP .IP
@ -196,9 +196,6 @@ If \fB\-\-ignore\-dependencies\fR is passed, skip installing any dependencies of
If \fB\-\-only\-dependencies\fR is passed, install the dependencies with specified options but do not install the specified formula\. If \fB\-\-only\-dependencies\fR is passed, install the dependencies with specified options but do not install the specified formula\.
. .
.IP .IP
If \fB\-\-fresh\fR is passed, the installation process will not re\-use any options from previous installs\.
.
.IP
If \fB\-\-cc=<compiler>\fR is passed, attempt to compile using \fIcompiler\fR\. \fIcompiler\fR should be the name of the compiler\'s executable, for instance \fBgcc\-4\.2\fR for Apple\'s GCC 4\.2, or \fBgcc\-4\.8\fR for a Homebrew\-provided GCC 4\.8\. If \fB\-\-cc=<compiler>\fR is passed, attempt to compile using \fIcompiler\fR\. \fIcompiler\fR should be the name of the compiler\'s executable, for instance \fBgcc\-4\.2\fR for Apple\'s GCC 4\.2, or \fBgcc\-4\.8\fR for a Homebrew\-provided GCC 4\.8\.
. .
.IP .IP