admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

tab: parse full Homebrew version string

Browse Source 
It didn't occur to me that this would work, but it does! Magic.
This commit is contained in:
Alyssa Ross 2016-12-30 18:15:35 +00:00
parent e5db7927c9
commit ce454bd141
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/tab.rb
View File

@ -248,7 +248,7 @@ class Tab < OpenStruct
def parsed_homebrew_version def parsed_homebrew_version
return Version::NULL if homebrew_version.nil? return Version::NULL if homebrew_version.nil?
Version.new(homebrew_tag) Version.new(homebrew_version)
end end
# Whether there is reliable runtime dependency information in the receipt. # Whether there is reliable runtime dependency information in the receipt.

11
Library/Homebrew/test/tab_test.rb
View File

@ -86,11 +86,18 @@ class TabTests < Homebrew::TestCase
tab = Tab.new(homebrew_version: "1.2.3") tab = Tab.new(homebrew_version: "1.2.3")
assert_equal "1.2.3", tab.parsed_homebrew_version assert_equal "1.2.3", tab.parsed_homebrew_version
assert tab.parsed_homebrew_version < "1.2.3-1-g12789abdf"
assert_kind_of Version, tab.parsed_homebrew_version assert_kind_of Version, tab.parsed_homebrew_version
tab.homebrew_version = "1.2.4-567-g12789abdf"
assert tab.parsed_homebrew_version > "1.2.4"
assert tab.parsed_homebrew_version > "1.2.4-566-g21789abdf"
assert tab.parsed_homebrew_version < "1.2.4-568-g01789abdf"
tab = Tab.new(homebrew_version: "2.0.0-134-gabcdefabc-dirty") tab = Tab.new(homebrew_version: "2.0.0-134-gabcdefabc-dirty")
assert_equal "2.0.0", tab.parsed_homebrew_version assert tab.parsed_homebrew_version > "2.0.0"
assert_kind_of Version, tab.parsed_homebrew_version assert tab.parsed_homebrew_version > "2.0.0-133-g21789abdf"
assert tab.parsed_homebrew_version < "2.0.0-135-g01789abdf"
end end
def test_reliable_runtime_dependencies? def test_reliable_runtime_dependencies?