admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #4267 from commitay/options-cop-formulae

Browse Source 
options_cop: formula -> formulae
This commit is contained in:
ilovezfs 2018-06-02 01:10:32 -07:00 committed by GitHub
commit cd6c990919
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/rubocops/options_cop.rb
View File

@ -46,8 +46,8 @@ module RuboCop
module NewFormulaAudit
class Options < FormulaCop
DEP_OPTION = "New Formula should not use `deprecated_option`".freeze
OPTION = "Formula should not have an `option`".freeze
DEP_OPTION = "New formulae should not use `deprecated_option`".freeze
OPTION = "Formulae should not have an `option`".freeze
def audit_formula(_node, _class_node, _parent_class_node, body_node)
return if versioned_formula?

4
Library/Homebrew/test/rubocops/options_cop_spec.rb
View File

@ -60,7 +60,7 @@ describe RuboCop::Cop::NewFormulaAudit::Options do
class Foo < Formula
url 'http://example.com/foo-1.0.tgz'
deprecated_option "examples" => "with-examples"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ New Formula should not use `deprecated_option`
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ New formulae should not use `deprecated_option`
end
RUBY
end
@ -70,7 +70,7 @@ describe RuboCop::Cop::NewFormulaAudit::Options do
class Foo < Formula
url 'http://example.com/foo-1.0.tgz'
option "with-examples"
^^^^^^^^^^^^^^^^^^^^^^ Formula should not have an `option`
^^^^^^^^^^^^^^^^^^^^^^ Formulae should not have an `option`
end
RUBY
end