admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocop: set LineLength to 118.

Browse Source 
GitHub diff UI wraps beyond 118 characters. This also allows enabling
`Style/IfUnlessModifier` (which autocorrects).
This commit is contained in:
Mike McQuaid 2020-03-12 20:39:15 +00:00
parent f5ba503aaa
commit cd3ced48e9
No known key found for this signature in database
GPG Key ID: 48A898132FD8EE70
3 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/.rubocop.yml
View File

@ -78,9 +78,9 @@ Metrics/ModuleLength:
Metrics/PerceivedComplexity: Metrics/PerceivedComplexity:
Enabled: false Enabled: false
# GitHub diff UI wraps beyond 118 characters (so that's the goal) # GitHub diff UI wraps beyond 118 characters
Layout/LineLength: Layout/LineLength:
Max: 167 Max: 118
# ignore manpage comments and long single-line strings # ignore manpage comments and long single-line strings
IgnoredPatterns: ['#: ', ' url "', ' mirror "', ' plist_options :'] IgnoredPatterns: ['#: ', ' url "', ' mirror "', ' plist_options :']

4
Library/.rubocop_shared.yml
View File

@ -58,9 +58,9 @@ Style/HashTransformKeys:
Style/HashTransformValues: Style/HashTransformValues:
Enabled: true Enabled: true
# This shouldn't be enabled until LineLength is lower. # Enabled now LineLength is lowish.
Style/IfUnlessModifier: Style/IfUnlessModifier:
Enabled: false Enabled: true
# Only use this for numbers >= `1_000_000`. # Only use this for numbers >= `1_000_000`.
Style/NumericLiterals: Style/NumericLiterals:

6
Library/Homebrew/.rubocop.yml
View File

@ -61,12 +61,6 @@ Metrics/PerceivedComplexity:
Enabled: true Enabled: true
Max: 100 Max: 100
# GitHub diff UI wraps beyond 118 characters
Layout/LineLength:
Max: 118
# ignore manpage comments
IgnoredPatterns: ['#: ']
# we won't change backward compatible predicate names # we won't change backward compatible predicate names
Naming/PredicateName: Naming/PredicateName:
Exclude: Exclude: