From cbbc932c21cce3451fb3f80a3d00b4f18908a976 Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Sat, 19 Dec 2020 19:55:57 +0100 Subject: [PATCH] Don't replace string inside of `MatchData`. --- Library/Homebrew/livecheck/strategy/bitbucket.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/livecheck/strategy/bitbucket.rb b/Library/Homebrew/livecheck/strategy/bitbucket.rb index c3e0007f1d..8066183e3d 100644 --- a/Library/Homebrew/livecheck/strategy/bitbucket.rb +++ b/Library/Homebrew/livecheck/strategy/bitbucket.rb @@ -56,7 +56,7 @@ module Homebrew match = url.match(URL_MATCH_REGEX) # Use `\.t` instead of specific tarball extensions (e.g. .tar.gz) - match[:suffix].sub!(/\.t(?:ar\..+|[a-z0-9]+)$/i, "\.t") + suffix = match[:suffix].sub(/\.t(?:ar\..+|[a-z0-9]+)$/i, "\.t") # `/get/` archives are Git tag snapshots, so we need to check that tab # instead of the main `/downloads/` page @@ -69,7 +69,7 @@ module Homebrew # Example regexes: # * `/href=.*?v?(\d+(?:\.\d+)+)\.t/i` # * `/href=.*?example-v?(\d+(?:\.\d+)+)\.t/i` - regex ||= /href=.*?#{Regexp.escape(match[:prefix])}v?(\d+(?:\.\d+)+)#{Regexp.escape(match[:suffix])}/i + regex ||= /href=.*?#{Regexp.escape(match[:prefix])}v?(\d+(?:\.\d+)+)#{Regexp.escape(suffix)}/i Homebrew::Livecheck::Strategy::PageMatch.find_versions(page_url, regex) end