From cba118533b83ba1587cf65da0142f58523d210e7 Mon Sep 17 00:00:00 2001 From: hyuraku <32809703+hyuraku@users.noreply.github.com> Date: Wed, 19 Apr 2023 21:06:27 +0900 Subject: [PATCH] remove cask/cmd specs --- .../Homebrew/test/cask/cmd/install_spec.rb | 131 ---------- Library/Homebrew/test/cask/quarantine_spec.rb | 227 ------------------ 2 files changed, 358 deletions(-) delete mode 100644 Library/Homebrew/test/cask/cmd/install_spec.rb delete mode 100644 Library/Homebrew/test/cask/quarantine_spec.rb diff --git a/Library/Homebrew/test/cask/cmd/install_spec.rb b/Library/Homebrew/test/cask/cmd/install_spec.rb deleted file mode 100644 index 19a2a1cf1a..0000000000 --- a/Library/Homebrew/test/cask/cmd/install_spec.rb +++ /dev/null @@ -1,131 +0,0 @@ -# typed: false -# frozen_string_literal: true - -describe Cask::Cmd::Install, :cask do - it "displays the installation progress" do - output = Regexp.new <<~EOS - ==> Downloading file:.*caffeine.zip - ==> Installing Cask local-caffeine - ==> Moving App 'Caffeine.app' to '.*Caffeine.app' - .*local-caffeine was successfully installed! - EOS - - expect do - described_class.run("local-caffeine") - end.to output(output).to_stdout - end - - it "allows staging and activation of multiple Casks at once" do - described_class.run("local-transmission", "local-caffeine") - transmission = Cask::CaskLoader.load(cask_path("local-transmission")) - caffeine = Cask::CaskLoader.load(cask_path("local-caffeine")) - expect(transmission).to be_installed - expect(transmission.config.appdir.join("Transmission.app")).to be_a_directory - expect(caffeine).to be_installed - expect(caffeine.config.appdir.join("Caffeine.app")).to be_a_directory - end - - it "recognizes the --appdir flag" do - appdir = mktmpdir - - expect(Cask::CaskLoader).to receive(:load) - .with("local-caffeine", any_args) - .and_wrap_original { |f, *args| - caffeine = f.call(*args) - expect(caffeine.config.appdir).to eq appdir - caffeine - } - - described_class.run("local-caffeine", "--appdir=#{appdir}") - end - - it "recognizes the --appdir flag from HOMEBREW_CASK_OPTS" do - appdir = mktmpdir - - expect(Cask::CaskLoader).to receive(:load) - .with("local-caffeine", any_args) - .and_wrap_original { |f, *args| - caffeine = f.call(*args) - expect(caffeine.config.appdir).to eq appdir - caffeine - } - - ENV["HOMEBREW_CASK_OPTS"] = "--appdir=#{appdir}" - - described_class.run("local-caffeine") - end - - it "prefers an explicit --appdir flag to one from HOMEBREW_CASK_OPTS" do - global_appdir = mktmpdir - appdir = mktmpdir - - expect(Cask::CaskLoader).to receive(:load) - .with("local-caffeine", any_args) - .and_wrap_original { |f, *args| - caffeine = f.call(*args) - expect(caffeine.config.appdir).to eq appdir - caffeine - } - - ENV["HOMEBREW_CASK_OPTS"] = "--appdir=#{global_appdir}" - - described_class.run("local-caffeine", "--appdir=#{appdir}") - end - - it "skips double install (without nuking existing installation)" do - described_class.run("local-transmission") - described_class.run("local-transmission") - expect(Cask::CaskLoader.load(cask_path("local-transmission"))).to be_installed - end - - it "prints a warning message on double install" do - described_class.run("local-transmission") - - expect do - described_class.run("local-transmission") - end.to output(/Warning: Cask 'local-transmission' is already installed./).to_stderr - end - - it "allows double install with --force" do - described_class.run("local-transmission") - - expect do - expect do - described_class.run("local-transmission", "--force") - end.to output(/It seems there is already an App at.*overwriting\./).to_stderr - end.to output(/local-transmission was successfully installed!/).to_stdout - end - - it "skips dependencies with --skip-cask-deps" do - described_class.run("with-depends-on-cask-multiple", "--skip-cask-deps") - expect(Cask::CaskLoader.load(cask_path("with-depends-on-cask-multiple"))).to be_installed - expect(Cask::CaskLoader.load(cask_path("local-caffeine"))).not_to be_installed - expect(Cask::CaskLoader.load(cask_path("local-transmission"))).not_to be_installed - end - - it "properly handles Casks that are not present" do - expect do - described_class.run("notacask") - end.to raise_error(Cask::CaskUnavailableError) - end - - it "returns a suggestion for a misspelled Cask" do - expect do - described_class.run("localcaffeine") - end.to raise_error( - Cask::CaskUnavailableError, - "Cask 'localcaffeine' is unavailable: No Cask with this name exists. " \ - "Did you mean 'local-caffeine'?", - ) - end - - it "returns multiple suggestions for a Cask fragment" do - expect do - described_class.run("local") - end.to raise_error( - Cask::CaskUnavailableError, - "Cask 'local' is unavailable: No Cask with this name exists. " \ - "Did you mean one of these?\nlocal-caffeine\nlocal-transmission\n", - ) - end -end diff --git a/Library/Homebrew/test/cask/quarantine_spec.rb b/Library/Homebrew/test/cask/quarantine_spec.rb deleted file mode 100644 index d08872fff6..0000000000 --- a/Library/Homebrew/test/cask/quarantine_spec.rb +++ /dev/null @@ -1,227 +0,0 @@ -# typed: false -# frozen_string_literal: true - -require "cask/cmd/install" -require "cask/cask_loader" -require "cask/download" -require "cask/quarantine" - -describe Cask::Quarantine, :cask do - matcher :be_quarantined do - match do |path| - expect( - described_class.detect(path), - ).to be true - end - end - - describe "by default" do - it "quarantines a nice fresh Cask" do - Cask::Cmd::Install.run("local-transmission") - - cask = Cask::CaskLoader.load(cask_path("local-transmission")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("Transmission.app")).to be_quarantined - end - - it "quarantines Cask fetches" do - download = Cask::Download.new(Cask::CaskLoader.load("local-transmission"), quarantine: true) - download.fetch - local_transmission = Cask::CaskLoader.load(cask_path("local-transmission")) - cached_location = Cask::Download.new(local_transmission).fetch - - expect(cached_location).to be_quarantined - end - - it "quarantines Cask installs even if the fetch was not" do - download = Cask::Download.new(Cask::CaskLoader.load("local-transmission"), quarantine: false) - download.fetch - - Cask::Cmd::Install.run("local-transmission") - - cask = Cask::CaskLoader.load(cask_path("local-transmission")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("Transmission.app")).to be_quarantined - end - - it "quarantines dmg-based Casks" do - Cask::Cmd::Install.run("container-dmg") - - cask = Cask::CaskLoader.load(cask_path("container-dmg")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("container")).to be_quarantined - end - - it "quarantines tar-gz-based Casks" do - Cask::Cmd::Install.run("container-tar-gz") - - cask = Cask::CaskLoader.load(cask_path("container-tar-gz")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("container")).to be_quarantined - end - - it "quarantines xar-based Casks" do - Cask::Cmd::Install.run("container-xar") - - cask = Cask::CaskLoader.load(cask_path("container-xar")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("container")).to be_quarantined - end - - it "quarantines pure bzip2-based Casks" do - Cask::Cmd::Install.run("container-bzip2") - - cask = Cask::CaskLoader.load(cask_path("container-bzip2")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("container")).to be_quarantined - end - - it "quarantines pure gzip-based Casks" do - Cask::Cmd::Install.run("container-gzip") - - cask = Cask::CaskLoader.load(cask_path("container-gzip")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("container")).to be_quarantined - end - - it "quarantines the pkg in naked-pkg-based Casks" do - Cask::Cmd::Install.run("container-pkg") - - cask = Cask::CaskLoader.load(cask_path("container-pkg")) - - expect(cask).to be_installed - - expect(cask.staged_path/"container.pkg").to be_quarantined - end - - it "quarantines a nested container" do - Cask::Cmd::Install.run("nested-app") - - cask = Cask::CaskLoader.load(cask_path("nested-app")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("MyNestedApp.app")).to be_quarantined - end - end - - describe "when disabled" do - it "does not quarantine even a nice, fresh Cask" do - Cask::Cmd::Install.run("local-transmission", "--no-quarantine") - - cask = Cask::CaskLoader.load(cask_path("local-transmission")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("Transmission.app")).not_to be_quarantined - end - - it "does not quarantine Cask fetches" do - download = Cask::Download.new(Cask::CaskLoader.load("local-transmission"), quarantine: false) - download.fetch - local_transmission = Cask::CaskLoader.load(cask_path("local-transmission")) - cached_location = Cask::Download.new(local_transmission).fetch - - expect(cached_location).not_to be_quarantined - end - - it "does not quarantine Cask installs even if the fetch was" do - download = Cask::Download.new(Cask::CaskLoader.load("local-transmission"), quarantine: true) - download.fetch - - Cask::Cmd::Install.run("local-transmission", "--no-quarantine") - - cask = Cask::CaskLoader.load(cask_path("local-transmission")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("Transmission.app")).not_to be_quarantined - end - - it "does not quarantine dmg-based Casks" do - Cask::Cmd::Install.run("container-dmg", "--no-quarantine") - - cask = Cask::CaskLoader.load(cask_path("container-dmg")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("container")).not_to be_quarantined - end - - it "does not quarantine tar-gz-based Casks" do - Cask::Cmd::Install.run("container-tar-gz", "--no-quarantine") - - cask = Cask::CaskLoader.load(cask_path("container-tar-gz")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("container")).not_to be_quarantined - end - - it "does not quarantine xar-based Casks" do - Cask::Cmd::Install.run("container-xar", "--no-quarantine") - - cask = Cask::CaskLoader.load(cask_path("container-xar")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("container")).not_to be_quarantined - end - - it "does not quarantine pure bzip2-based Casks" do - Cask::Cmd::Install.run("container-bzip2", "--no-quarantine") - - cask = Cask::CaskLoader.load(cask_path("container-bzip2")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("container")).not_to be_quarantined - end - - it "does not quarantine pure gzip-based Casks" do - Cask::Cmd::Install.run("container-gzip", "--no-quarantine") - - cask = Cask::CaskLoader.load(cask_path("container-gzip")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("container")).not_to be_quarantined - end - - it "does not quarantine the pkg in naked-pkg-based Casks" do - Cask::Cmd::Install.run("container-pkg", "--no-quarantine") - - naked_pkg = Cask::CaskLoader.load(cask_path("container-pkg")) - - expect(naked_pkg).to be_installed - - expect( - Cask::Caskroom.path.join("container-pkg", naked_pkg.version, "container.pkg"), - ).not_to be_quarantined - end - - it "does not quarantine a nested container" do - Cask::Cmd::Install.run("nested-app", "--no-quarantine") - - cask = Cask::CaskLoader.load(cask_path("nested-app")) - - expect(cask).to be_installed - - expect(cask.config.appdir.join("MyNestedApp.app")).not_to be_quarantined - end - end -end