admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocop: Enable Style/AccessorGrouping and autofix offenses

Browse Source 
- With RuboCop 1.48.1 this no longer reports offenses and applies bugged
  autocorrections for `attr`s with Sorbet `sig`s, so we can enable it.
This commit is contained in:
Issy Long 2023-03-13 23:59:25 +00:00
parent 8a5e1697a6
commit cace5c429f
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/.rubocop.yml
View File

@ -301,10 +301,6 @@ Sorbet/StrictSigil:
Include: Include:
- "**/*.rbi" - "**/*.rbi"
# Conflicts with type signatures on `attr_*`s.
Style/AccessorGrouping:
Enabled: false
# Require &&/|| instead of and/or # Require &&/|| instead of and/or
Style/AndOr: Style/AndOr:
EnforcedStyle: always EnforcedStyle: always

4
Library/Homebrew/utils/pypi.rb
View File

@ -18,9 +18,7 @@ module PyPI
class Package class Package
extend T::Sig extend T::Sig
attr_accessor :name attr_accessor :name, :extras, :version
attr_accessor :extras
attr_accessor :version
sig { params(package_string: String, is_url: T::Boolean).void } sig { params(package_string: String, is_url: T::Boolean).void }
def initialize(package_string, is_url: false) def initialize(package_string, is_url: false)