admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Cache Hardware.is_64_bit?

Browse Source 
IO#popen is called for each call to Hardware.is_64_bit?; this becomes
costly when it is repeatedly invoked. Luckily it is an invariant, so we
can store it in a class variable.

False is a valid value for this method, so the usual ||= idiom is not
applicable.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Jack Nagel 2012-04-11 20:19:52 -05:00
parent 168ccb2821
commit ca71c038a1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/hardware.rb
View File

@ -55,7 +55,8 @@ class Hardware
end end
def self.is_64_bit? def self.is_64_bit?
self.sysctl_bool("hw.cpu64bit_capable") return @@is_64_bit if defined? @@is_64_bit
@@is_64_bit = self.sysctl_bool("hw.cpu64bit_capable")
end end
def self.bits def self.bits