From c9a4e1e1c932bbc69d35a2f544955c956552165d Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Wed, 14 Aug 2013 14:13:03 -0500 Subject: [PATCH] Use each instead of while loop --- Library/Homebrew/python_helper.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Library/Homebrew/python_helper.rb b/Library/Homebrew/python_helper.rb index c99fce2c74..18dbbe216f 100644 --- a/Library/Homebrew/python_helper.rb +++ b/Library/Homebrew/python_helper.rb @@ -33,8 +33,7 @@ def python_helper(options={:allowed_major_versions => [2, 3]}, &block) # check that no two python binaries are the same (which could be the case # because more than one `depends_on :python => 'module_name' may be present). filtered_python_reqs = [] - while !python_reqs.empty? - py = python_reqs.shift + python_reqs.each do |py| next if filtered_python_reqs.any? { |req| req.binary == py.binary } next unless py.satisfied? next unless options[:allowed_major_versions].include?(py.version.major)