brew audit - Google Code homes w/o trailing slash

Without a trailing slash, you redirect to the URL w/ a slash, so
might as well have it there in the first place.
This commit is contained in:
Adam Vandenberg 2010-08-21 11:55:57 -07:00
parent c9d41345d0
commit c905fb79f4

View File

@ -103,8 +103,7 @@ def audit_formula_options f, text
return problems
end
def audit_some_formulae
ff.each do |f|
def audit_formula_instance f
problems = []
# Don't depend_on aliases; use full name
@ -113,6 +112,20 @@ def audit_some_formulae
problems << " * Dep #{d} is an alias; switch to the real name."
end
# Google Code homepages should end in a slash
if f.homepage =~ %r[^https?://code\.google\.com/p/[^/]+[^/]$]
problems << " * Google Code homepage should end with a slash."
end
return problems
end
def audit_some_formulae
ff.each do |f|
problems = []
problems += audit_formula_instance f
text = ""
File.open(f.path, "r") { |afile| text = afile.read }