From e8f2d8f6c5b8d53075b7500ba26ccaae79a7bcd1 Mon Sep 17 00:00:00 2001
From: Rylan Polster <rslpolster@gmail.com>
Date: Wed, 14 Sep 2022 23:54:14 -0400
Subject: [PATCH] Load formulae from their aliases using the API

---
 Library/Homebrew/api/formula.rb       | 14 +++++++++++++-
 Library/Homebrew/formula_installer.rb |  2 +-
 Library/Homebrew/formulary.rb         | 20 +++++++++++++++++---
 3 files changed, 31 insertions(+), 5 deletions(-)

diff --git a/Library/Homebrew/api/formula.rb b/Library/Homebrew/api/formula.rb
index 4011403a32..52f3d7018b 100644
--- a/Library/Homebrew/api/formula.rb
+++ b/Library/Homebrew/api/formula.rb
@@ -26,7 +26,7 @@ module Homebrew
           Homebrew::API.fetch "#{formula_api_path}/#{name}.json"
         end
 
-        sig { returns(Array) }
+        sig { returns(Hash) }
         def all_formulae
           @all_formulae ||= begin
             curl_args = %w[--compressed --silent https://formulae.brew.sh/api/formula.json]
@@ -37,11 +37,23 @@ module Homebrew
 
             json_formulae = JSON.parse(cached_formula_json_file.read)
 
+            @all_aliases = {}
             json_formulae.to_h do |json_formula|
+              json_formula["aliases"].each do |alias_name|
+                @all_aliases[alias_name] = json_formula["name"]
+              end
+
               [json_formula["name"], json_formula.except("name")]
             end
           end
         end
+
+        sig { returns(Hash) }
+        def all_aliases
+          all_formulae if @all_aliases.blank?
+
+          @all_aliases
+        end
       end
     end
   end
diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb
index e0a696fd0e..5b5918c019 100644
--- a/Library/Homebrew/formula_installer.rb
+++ b/Library/Homebrew/formula_installer.rb
@@ -1165,7 +1165,7 @@ class FormulaInstaller
 
     if pour_bottle?(output_warning: true)
       formula.fetch_bottle_tab
-    elsif Homebrew::EnvConfig.install_from_api?
+    elsif formula.core_formula? && Homebrew::EnvConfig.install_from_api?
       odie "Unable to build #{formula.name} from source with HOMEBREW_INSTALL_FROM_API."
     else
       formula.fetch_patches
diff --git a/Library/Homebrew/formulary.rb b/Library/Homebrew/formulary.rb
index 658b211c62..9c5761ce4d 100644
--- a/Library/Homebrew/formulary.rb
+++ b/Library/Homebrew/formulary.rb
@@ -529,6 +529,14 @@ module Formulary
     end
   end
 
+  # Load aliases from the API.
+  class AliasAPILoader < FormulaAPILoader
+    def initialize(alias_name)
+      super Homebrew::API::Formula.all_aliases[alias_name]
+      @alias_path = Formulary.core_alias_path(alias_name).to_s
+    end
+  end
+
   # Return a {Formula} instance for the given reference.
   # `ref` is a string containing:
   #
@@ -655,6 +663,7 @@ module Formulary
       if ref.start_with?("homebrew/core/") && Homebrew::EnvConfig.install_from_api?
         name = ref.split("/", 3).last
         return FormulaAPILoader.new(name) if Homebrew::API::Formula.all_formulae.key?(name)
+        return AliasAPILoader.new(name) if Homebrew::API::Formula.all_aliases.key?(name)
       end
 
       return TapLoader.new(ref, from: from)
@@ -662,14 +671,15 @@ module Formulary
 
     return FromPathLoader.new(ref) if File.extname(ref) == ".rb" && Pathname.new(ref).expand_path.exist?
 
-    if Homebrew::EnvConfig.install_from_api? && Homebrew::API::Formula.all_formulae.key?(ref)
-      return FormulaAPILoader.new(ref)
+    if Homebrew::EnvConfig.install_from_api?
+      return FormulaAPILoader.new(ref) if Homebrew::API::Formula.all_formulae.key?(ref)
+      return AliasAPILoader.new(ref) if Homebrew::API::Formula.all_aliases.key?(ref)
     end
 
     formula_with_that_name = core_path(ref)
     return FormulaLoader.new(ref, formula_with_that_name) if formula_with_that_name.file?
 
-    possible_alias = CoreTap.instance.alias_dir/ref
+    possible_alias = core_alias_path(ref)
     return AliasLoader.new(possible_alias) if possible_alias.file?
 
     possible_tap_formulae = tap_paths(ref)
@@ -705,6 +715,10 @@ module Formulary
     CoreTap.instance.formula_dir/"#{name.to_s.downcase}.rb"
   end
 
+  def self.core_alias_path(name)
+    CoreTap.instance.alias_dir/name.to_s.downcase
+  end
+
   def self.tap_paths(name, taps = Dir[HOMEBREW_LIBRARY/"Taps/*/*/"])
     name = name.to_s.downcase
     taps.map do |tap|