From c8c85b4ac424a9da2ea426ae150c2e860f693ac4 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Sat, 29 Mar 2014 17:47:42 -0500 Subject: [PATCH] Always call Process.wait with an argument --- Library/Homebrew/formula.rb | 4 ++-- Library/Homebrew/utils.rb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index 9d6f525bad..81b546388b 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -572,7 +572,7 @@ class Formula logfn = "#{logd}/%02d.%s" % [@exec_count, File.basename(cmd).split(' ').first] mkdir_p(logd) - fork do + pid = fork do ENV['HOMEBREW_CC_LOG_PATH'] = logfn # TODO system "xcodebuild" is deprecated, this should be removed soon. @@ -603,7 +603,7 @@ class Formula puts buf if ARGV.verbose? end - Process.wait + Process.wait(pid) $stdout.flush diff --git a/Library/Homebrew/utils.rb b/Library/Homebrew/utils.rb index 8fa86797fd..ac84c16025 100644 --- a/Library/Homebrew/utils.rb +++ b/Library/Homebrew/utils.rb @@ -84,8 +84,8 @@ def interactive_shell f=nil ENV['HOMEBREW_DEBUG_INSTALL'] = f.name end - fork {exec ENV['SHELL'] } - Process.wait + Process.wait fork { exec ENV['SHELL'] } + unless $?.success? puts "Aborting due to non-zero exit status" exit $?