admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Optimize deleted_reason for all taps

Browse Source
This commit is contained in:
apainintheneck 2022-11-15 00:04:02 -08:00
parent 2bc54e56e4
commit c787df5294
1 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
Library/Homebrew/missing_formula.rb
View File

@ -154,25 +154,17 @@ module Homebrew
end
end
# The core tap has thousands of monthly commits making the `git log`
# command below a performance issue when using `brew search` or
# `brew info` to look for a formula that doesn't exist. This first
# checks if the formula existed a month ago before continuing.
if tap.is_a? CoreTap
commit_command = "git log --before='1 month ago' --max-count=1 --format=%H"
month_old_commit_hash = Utils.popen_read(commit_command).chomp
# Check if the formula has been deleted in the last month.
diff_command = ["git", "diff", "--diff-filter=D", "--name-only",
"@{'1 month ago'}", "--", relative_path]
deleted_formula = Utils.popen_read(*diff_command)
# Check if the formula has been deleted in the last month
# by comparing the diff between now and a month ago.
diff_command = "git diff --diff-filter=D --name-only " \
"#{month_old_commit_hash} HEAD -- #{relative_path}"
if Utils.popen_read(diff_command).blank?
ofail "No previously deleted formula found." unless silent
return
end
if deleted_formula.blank?
ofail "No previously deleted formula found." unless silent
return
end
# Find commit where formula was deleted in the last month.
log_command = "git log --since='1 month ago' --diff-filter=D " \
"--name-only --max-count=1 " \
"--format=%H\\\\n%h\\\\n%B -- #{relative_path}"