diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index 4438c1f1ed..75e1a2a066 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -2872,7 +2872,7 @@ class Formula ).void } def inreplace(paths, before = nil, after = nil, old_audit_result = nil, audit_result: true, &block) - # NOTE: must check for `#nil?` and not `#blank?`. + # NOTE: must check for `#nil?` and not `#blank?`, or else `old_audit_result = false` will not call `odeprecated`. unless old_audit_result.nil? # odeprecated "inreplace(paths, before, after, #{old_audit_result})", # "inreplace(paths, before, after, audit_result: #{old_audit_result})" diff --git a/Library/Homebrew/utils/string_inreplace_extension.rb b/Library/Homebrew/utils/string_inreplace_extension.rb index b140c1fa72..e1a1cc625e 100644 --- a/Library/Homebrew/utils/string_inreplace_extension.rb +++ b/Library/Homebrew/utils/string_inreplace_extension.rb @@ -37,7 +37,7 @@ class StringInreplaceExtension ).returns(T.nilable(String)) } def gsub!(before, after, old_audit_result = nil, audit_result: true) - # NOTE: must check for `#nil?` and not `#blank?`. + # NOTE: must check for `#nil?` and not `#blank?`, or else `old_audit_result = false` will not call `odeprecated`. unless old_audit_result.nil? # odeprecated "gsub!(before, after, #{old_audit_result})", # "gsub!(before, after, audit_result: #{old_audit_result})"