admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #3604 from alyssais/cask_no_arguments

Browse Source 
cask: exit successfully when given no arguments.
This commit is contained in:
Mike McQuaid 2017-12-29 15:53:39 +00:00 committed by GitHub
commit c6eaa73db1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Library/Homebrew/cask/lib/hbc/cli.rb
View File

@ -229,6 +229,7 @@ module Hbc
purpose purpose
usage usage
return if @command.nil?
return if @command == "help" && @args.empty? return if @command == "help" && @args.empty?
raise ArgumentError, "help does not take arguments." raise ArgumentError, "help does not take arguments."

8
Library/Homebrew/test/cask/cli_spec.rb
View File

@ -16,10 +16,16 @@ describe Hbc::CLI, :cask do
it "ignores the `--language` option, which is handled in `OS::Mac`" do it "ignores the `--language` option, which is handled in `OS::Mac`" do
cli = described_class.new("--language=en") cli = described_class.new("--language=en")
expect(cli).to receive(:detect_command_and_arguments).with(no_args) expect(cli).to receive(:detect_command_and_arguments).with(no_args)
expect(cli).to receive(:exit).with(1)
cli.run cli.run
end end
context "when given no arguments" do
it "exits successfully" do
expect(subject).not_to receive(:exit).with(be_nonzero)
subject.run
end
end
context "when no option is specified" do context "when no option is specified" do
it "--binaries is true by default" do it "--binaries is true by default" do
command = Hbc::CLI::Install.new("some-cask") command = Hbc::CLI::Install.new("some-cask")