From c61492ac91ae65db2ba5afc8d5f41a0580fb8182 Mon Sep 17 00:00:00 2001 From: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Date: Mon, 26 Aug 2024 20:05:21 +0800 Subject: [PATCH] Fix logic error in `active_runner?` We should only activate a runner when there are deleted formulae if it isn't a dependent matrix. --- Library/Homebrew/github_runner_matrix.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/github_runner_matrix.rb b/Library/Homebrew/github_runner_matrix.rb index ea99a7cbc5..83c2d862f0 100644 --- a/Library/Homebrew/github_runner_matrix.rb +++ b/Library/Homebrew/github_runner_matrix.rb @@ -210,9 +210,10 @@ class GitHubRunnerMatrix sig { params(runner: GitHubRunner).returns(T::Boolean) } def active_runner?(runner) - return true if @all_supported || @deleted_formulae.present? + return true if @all_supported + return true if @deleted_formulae.present? && !@dependent_matrix - testable_formulae(runner).present? + runner.spec.testing_formulae.present? end sig { params(runner: GitHubRunner).returns(T::Array[TestRunnerFormula]) }