cask: audit for correct signing of pkg installers
This commit is contained in:
parent
853b33bcda
commit
c5786ea799
@ -491,22 +491,20 @@ module Cask
|
|||||||
Dir.mktmpdir do |tmpdir|
|
Dir.mktmpdir do |tmpdir|
|
||||||
tmpdir = Pathname(tmpdir)
|
tmpdir = Pathname(tmpdir)
|
||||||
primary_container.extract_nestedly(to: tmpdir, basename: downloaded_path.basename, verbose: false)
|
primary_container.extract_nestedly(to: tmpdir, basename: downloaded_path.basename, verbose: false)
|
||||||
|
|
||||||
|
message = "Signature verification failed:\n#{result.merged_output}\nmacOS on ARM requires applications " \
|
||||||
|
"to be signed. Please contact the upstream developer to let them know they should "
|
||||||
|
|
||||||
artifacts.each do |artifact|
|
artifacts.each do |artifact|
|
||||||
path = case artifact
|
case artifact
|
||||||
when Artifact::Moved
|
when Artifact::Moved
|
||||||
tmpdir/artifact.source.basename
|
path = tmpdir/artifact.source.basename
|
||||||
when Artifact::Pkg
|
|
||||||
artifact.path
|
|
||||||
end
|
|
||||||
next unless path.exist?
|
next unless path.exist?
|
||||||
|
|
||||||
result = system_command("codesign", args: ["--verify", path], print_stderr: false)
|
result = system_command("codesign", args: ["--verify", path], print_stderr: false)
|
||||||
|
|
||||||
next if result.success?
|
next if result.success?
|
||||||
|
|
||||||
message = "Signature verification failed:\n#{result.merged_output}\nmacOS on ARM requires applications " \
|
|
||||||
"to be signed. Please contact the upstream developer to let them know they should "
|
|
||||||
|
|
||||||
message += if result.stderr.include?("not signed at all")
|
message += if result.stderr.include?("not signed at all")
|
||||||
"sign their app."
|
"sign their app."
|
||||||
else
|
else
|
||||||
@ -514,6 +512,22 @@ module Cask
|
|||||||
end
|
end
|
||||||
|
|
||||||
add_warning message
|
add_warning message
|
||||||
|
when Artifact::Pkg
|
||||||
|
path = artifact.path
|
||||||
|
next unless path.exist?
|
||||||
|
|
||||||
|
result = system_command("pkgutil", args: ["--check-signature", path], print_stderr: false)
|
||||||
|
if result.failure?
|
||||||
|
add_warning "#{message} sign their package."
|
||||||
|
next
|
||||||
|
end
|
||||||
|
|
||||||
|
result = system_command("stapler", args: ["validate", path], print_stderr: false)
|
||||||
|
if result.failure?
|
||||||
|
add_warning "#{message} notarize their package."
|
||||||
|
next
|
||||||
|
end
|
||||||
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user