admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit (strict): add require formula check.

Browse Source
This commit is contained in:
Mike McQuaid 2014-12-27 15:59:16 +00:00
parent f3a5a83452
commit c4f7217811
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Homebrew/cmd/audit.rb
View File

@ -41,6 +41,7 @@ class FormulaText
@text = path.open("rb", &:read) @text = path.open("rb", &:read)
end end
def without_patch def without_patch
@text.split("\n__END__").first @text.split("\n__END__").first
end end
@ -565,6 +566,10 @@ class FormulaAuditor
good_quotes = bad_quotes.gsub "'", "\"" good_quotes = bad_quotes.gsub "'", "\""
problem "use double-quotes for `#{good_quotes}` instead of `#{bad_quotes}`" problem "use double-quotes for `#{good_quotes}` instead of `#{bad_quotes}`"
end end
if line =~ /(require ["']formula["'])/
problem "`#{$1}` is now unnecessary"
end
end end
end end