From 7eb1fd66710a8e620683fc6d18089fc15e81e945 Mon Sep 17 00:00:00 2001
From: Mike McQuaid <mike@mikemcquaid.com>
Date: Sat, 30 Dec 2017 21:23:33 +0000
Subject: [PATCH] reinstall/upgrade: document use of options.

To avoid user confusion e.g. #3606.
---
 Library/Homebrew/cmd/reinstall.rb | 2 +-
 Library/Homebrew/cmd/upgrade.rb   | 2 +-
 docs/Manpage.md                   | 4 ++--
 manpages/brew.1                   | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Library/Homebrew/cmd/reinstall.rb b/Library/Homebrew/cmd/reinstall.rb
index 6727c0b6bb..a4629025ae 100644
--- a/Library/Homebrew/cmd/reinstall.rb
+++ b/Library/Homebrew/cmd/reinstall.rb
@@ -1,5 +1,5 @@
 #:  * `reinstall` <formula>:
-#:    Uninstall and then install <formula>.
+#:    Uninstall and then install <formula> (with existing install options).
 
 require "formula_installer"
 require "development_tools"
diff --git a/Library/Homebrew/cmd/upgrade.rb b/Library/Homebrew/cmd/upgrade.rb
index 9f8763904b..cf0bb27595 100644
--- a/Library/Homebrew/cmd/upgrade.rb
+++ b/Library/Homebrew/cmd/upgrade.rb
@@ -1,5 +1,5 @@
 #:  * `upgrade` [<install-options>] [`--cleanup`] [`--fetch-HEAD`] [<formulae>]:
-#:    Upgrade outdated, unpinned brews.
+#:    Upgrade outdated, unpinned brews (with existing install options).
 #:
 #:    Options for the `install` command are also valid here.
 #:
diff --git a/docs/Manpage.md b/docs/Manpage.md
index f42009ab54..51affc32c4 100644
--- a/docs/Manpage.md
+++ b/docs/Manpage.md
@@ -397,7 +397,7 @@ With `--verbose` or `-v`, many commands print extra debugging information. Note
     all formulae or to determine if any current formulae have Ruby issues.
 
   * `reinstall` `formula`:
-    Uninstall and then install `formula`.
+    Uninstall and then install `formula` (with existing install options).
 
   * `search`, `-S`:
     Display all locally available formulae for brewing (including tapped ones).
@@ -569,7 +569,7 @@ With `--verbose` or `-v`, many commands print extra debugging information. Note
     or committed changes.
 
   * `upgrade` [`install-options`] [`--cleanup`] [`--fetch-HEAD`] [`formulae`]:
-    Upgrade outdated, unpinned brews.
+    Upgrade outdated, unpinned brews (with existing install options).
 
     Options for the `install` command are also valid here.
 
diff --git a/manpages/brew.1 b/manpages/brew.1
index d8cea89752..ba13b56804 100644
--- a/manpages/brew.1
+++ b/manpages/brew.1
@@ -406,7 +406,7 @@ This can be useful for debugging issues across all formulae when making signific
 .
 .TP
 \fBreinstall\fR \fIformula\fR
-Uninstall and then install \fIformula\fR\.
+Uninstall and then install \fIformula\fR (with existing install options)\.
 .
 .TP
 \fBsearch\fR, \fB\-S\fR
@@ -584,7 +584,7 @@ Fetches and resets Homebrew and all tap repositories using \fBgit\fR(1) to their
 .
 .TP
 \fBupgrade\fR [\fIinstall\-options\fR] [\fB\-\-cleanup\fR] [\fB\-\-fetch\-HEAD\fR] [\fIformulae\fR]
-Upgrade outdated, unpinned brews\.
+Upgrade outdated, unpinned brews (with existing install options)\.
 .
 .IP
 Options for the \fBinstall\fR command are also valid here\.