From c3f8ffbb10ef9aa8260f522c5260692123049b68 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Fri, 13 Jul 2018 08:05:33 +0100 Subject: [PATCH] extend/fileutils: fix monkeypatch. Otherwise using the options argument or relying on a result means this method will fail. This is why monkeypatching sucks. CC @reitermarkus as we've talked about monkeypatching recently. --- Library/Homebrew/extend/fileutils.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/extend/fileutils.rb b/Library/Homebrew/extend/fileutils.rb index ea2d51c01b..eebe54e373 100644 --- a/Library/Homebrew/extend/fileutils.rb +++ b/Library/Homebrew/extend/fileutils.rb @@ -86,9 +86,9 @@ module FileUtils alias old_mkdir mkdir # A version of mkdir that also changes to that folder in a block. - def mkdir(name, &_block) - mkdir_p(name) - return unless block_given? + def mkdir(name, mode: nil, noop: nil, verbose: nil, &_block) + result = mkdir_p(name, mode: mode, noop: noop, verbose: verbose) + return result unless block_given? chdir name do yield end