admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Don't use "assert_not_nil"

Browse Source
This commit is contained in:
Jack Nagel 2013-04-02 15:33:34 -05:00
parent 207f24be07
commit c3d48b5d8a
2 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/test/test_dependency_collector.rb
View File

@ -20,7 +20,7 @@ class DependencyCollectorTests < Test::Unit::TestCase
def test_dependency_creation def test_dependency_creation
@d.add 'foo' => :build @d.add 'foo' => :build
@d.add 'bar' => ['--universal', :optional] @d.add 'bar' => ['--universal', :optional]
assert_not_nil @d.find_dependency('foo') assert_instance_of Dependency, @d.find_dependency('foo')
assert_equal 2, @d.find_dependency('bar').tags.length assert_equal 2, @d.find_dependency('bar').tags.length
end end
@ -45,7 +45,7 @@ class DependencyCollectorTests < Test::Unit::TestCase
def test_requirement_creation def test_requirement_creation
@d.add :x11 @d.add :x11
assert_not_nil @d.find_requirement(X11Dependency) assert_instance_of X11Dependency, @d.find_requirement(X11Dependency)
end end
def test_no_duplicate_requirements def test_no_duplicate_requirements

9
Library/Homebrew/test/test_formula.rb
View File

@ -160,7 +160,6 @@ class FormulaTests < Test::Unit::TestCase
def test_head_only_specs def test_head_only_specs
f = HeadOnlySpecTestBall.new f = HeadOnlySpecTestBall.new
assert_not_nil f.head
assert_nil f.stable assert_nil f.stable
assert_nil f.bottle assert_nil f.bottle
assert_nil f.devel assert_nil f.devel
@ -177,7 +176,6 @@ class FormulaTests < Test::Unit::TestCase
def test_incomplete_stable_specs def test_incomplete_stable_specs
f = IncompleteStableSpecTestBall.new f = IncompleteStableSpecTestBall.new
assert_not_nil f.head
assert_nil f.stable assert_nil f.stable
assert_nil f.bottle assert_nil f.bottle
assert_nil f.devel assert_nil f.devel
@ -194,7 +192,6 @@ class FormulaTests < Test::Unit::TestCase
def test_head_only_with_version_specs def test_head_only_with_version_specs
f = IncompleteStableSpecTestBall.new f = IncompleteStableSpecTestBall.new
assert_not_nil f.head
assert_nil f.stable assert_nil f.stable
assert_nil f.bottle assert_nil f.bottle
assert_nil f.devel assert_nil f.devel
@ -211,9 +208,9 @@ class FormulaTests < Test::Unit::TestCase
def test_explicit_strategy_specs def test_explicit_strategy_specs
f = ExplicitStrategySpecTestBall.new f = ExplicitStrategySpecTestBall.new
assert_not_nil f.stable assert_instance_of SoftwareSpec, f.stable
assert_not_nil f.devel assert_instance_of SoftwareSpec, f.devel
assert_not_nil f.head assert_instance_of HeadSoftwareSpec, f.head
assert_equal f.stable, f.active_spec assert_equal f.stable, f.active_spec