admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

dev-cmd/contributions: Split git_log_cmd into two methods

Browse Source 
- Otherwise it's quite involved and a bit hard to read.
This commit is contained in:
Issy Long 2022-07-24 23:24:52 +01:00
parent fef9a286fe
commit c330ea4e3b
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
Library/Homebrew/dev-cmd/contributions.rb
View File

@ -53,8 +53,8 @@ module Homebrew
repo_path = find_repo_path_for_repo(repo)
return ofail "Couldn't find repo #{repo} locally. Run `brew tap homebrew/#{repo}`." unless repo_path.exist?
commits += git_log_cmd("author", repo_path, args)
coauthorships += git_log_cmd("coauthorships", repo_path, args)
commits += git_log_author_cmd(repo_path, args)
coauthorships += git_log_coauthor_cmd(repo_path, args)
end
sentence = "Person #{args[:email]} directly authored #{commits} commits"
@ -81,14 +81,22 @@ module Homebrew
Tap.fetch("homebrew", repo).path
end
sig { params(kind: String, repo_path: String, args: Homebrew::CLI::Args).returns(Integer) }
def git_log_cmd(kind, repo_path, args)
cmd = "git -C #{repo_path} log --oneline"
cmd += " --author=#{args[:email]}" if kind == "author"
cmd += " --format='%(trailers:key=Co-authored-by:)'" if kind == "coauthorships"
sig { params(repo_path: String, args: Homebrew::CLI::Args).returns(Integer) }
def git_log_author_cmd(repo_path, args)
cmd = "git -C #{repo_path} log --oneline --author=#{args[:email]}"
cmd += " --before=#{args[:to]}" if args[:to]
cmd += " --after=#{args[:from]}" if args[:from]
cmd += " | grep #{args[:email]}" if kind == "coauthorships"
`#{cmd} | wc -l`.strip.to_i
end
sig { params(repo_path: String, args: Homebrew::CLI::Args).returns(Integer) }
def git_log_coauthor_cmd(repo_path, args)
cmd = "git -C #{repo_path} log --oneline"
cmd += " --format='%(trailers:key=Co-authored-by:)'"
cmd += " --before=#{args[:to]}" if args[:to]
cmd += " --after=#{args[:from]}" if args[:from]
cmd += " | grep #{args[:email]}"
`#{cmd} | wc -l`.strip.to_i
end