From c27ba5c4bd9dc077978aad4b1170cf75df8e5ae7 Mon Sep 17 00:00:00 2001 From: Frizlab Date: Sat, 16 Feb 2019 14:40:29 +0100 Subject: [PATCH] Print a warning when a recursive upgradable or broken dependant has been found --- Library/Homebrew/cmd/upgrade.rb | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cmd/upgrade.rb b/Library/Homebrew/cmd/upgrade.rb index 5ee3fa7d0b..a7b0aa6198 100644 --- a/Library/Homebrew/cmd/upgrade.rb +++ b/Library/Homebrew/cmd/upgrade.rb @@ -226,7 +226,11 @@ module Homebrew dependent_formulae.each do |f| next if formulae_to_upgrade.include?(f) next if formulae_pinned.include?(f) - next if formulae_visited.include?(f) + + if formulae_visited.include?(f) + opoo "Found recursive upgradable dependent #{f.full_name}" + next + end formulae_visited << f @@ -271,7 +275,11 @@ module Homebrew next if formulae_to_reinstall.include?(f) next if formulae_pinned_and_outdated.include?(f) - next if formulae_visited.include?(f) + + if formulae_visited.include?(f) + opoo "Found recursive broken dependent #{f.full_name}" + next + end formulae_visited << f