admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Fix string interpolation detection again to be even broader

Browse Source 
- My approach wasn't quite good enough. Replace it with what RuboCop
  itself does to detect all forms of string interpolation.
This commit is contained in:
Issy Long 2023-03-23 13:16:10 +00:00
parent 0889593e2a
commit c1de3dfb90
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/rubocops/cask/no_overrides.rb
View File

@ -42,8 +42,8 @@ module RuboCop
child.each_node(:send) do |send_node| child.each_node(:send) do |send_node|
# Skip (nested) livecheck blocks as its `url` is different to a download `url`. # Skip (nested) livecheck blocks as its `url` is different to a download `url`.
next if send_node.method_name == :livecheck || inside_livecheck_block?(send_node) next if send_node.method_name == :livecheck || inside_livecheck_block?(send_node)
# Skip string interpolations (`:send` inside `:begin` inside `:dstr`). # Skip string interpolations.
next if send_node.parent.begin_type? && send_node.parent.parent.dstr_type? next if send_node.ancestors.drop_while { |a| !a.begin_type? }.any?(&:dstr_type?)
next if ON_SYSTEM_METHODS.include?(send_node.method_name) next if ON_SYSTEM_METHODS.include?(send_node.method_name)
names.add(send_node.method_name) names.add(send_node.method_name)